Skip to content

[HUDI-9273] Upgrade Parquet to 1.15.1 to address CVE-2025-30065#13315

Closed
adith-os wants to merge 2 commits intoapache:masterfrom
adith-os:HUDI-9273-upgrade-parquet-version
Closed

[HUDI-9273] Upgrade Parquet to 1.15.1 to address CVE-2025-30065#13315
adith-os wants to merge 2 commits intoapache:masterfrom
adith-os:HUDI-9273-upgrade-parquet-version

Conversation

@adith-os
Copy link
Contributor

Change Logs

This code change is made to update jetty version to fix CVE-2025-30065. Changing the version caused failures for application runs for Apache spark where it was manually tested due to change in the dependencies required for parquet-avro for version 1.15.1. This is currently resolved by shading the required dependencies.

Impact

Fixes the vulnerability

Risk level (write none, low medium or high below)

Low

Documentation Update

None

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label May 18, 2025
@adith-os
Copy link
Contributor Author

Please review and guide on better approaches or any changes required for other modules for this update. Thanks!

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

bringing these file-formats as dependencies as well, we need to make sure that versions are
synchronized to avoid classpath ambiguity -->
<parquet.version>1.13.1</parquet.version>
<parquet.version>1.15.1</parquet.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the version backward compatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out or find any mention of backward compatibility for this version with older versions. However, I noticed that adding this version does cause failures because now it is dependent on other parquet packages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but still, thanks for the contribution, is the fix a blocker for you?

Copy link
Contributor Author

@adith-os adith-os May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. It is not a blocker for me, I could fix errors like the below one by shading the required parquet packages for spark-bundle for my usecase. I wanted to contribute the same change but I see the same error in the tests which is a bit confusing 😅

recent failure: Lost task 0.3 in stage 12.0 (TID 26) (172.30.95.61 executor 1): java.lang.NoClassDefFoundError: org.apache.parquet.conf.HadoopParquetConfiguration
	at org.apache.parquet.avro.AvroSchemaConverter.<init>(AvroSchemaConverter.java:111)

bringing these file-formats as dependencies as well, we need to make sure that versions are
synchronized to avoid classpath ambiguity -->
<parquet.version>1.12.2</parquet.version>
<parquet.version>1.15.1</parquet.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this cannot be changed and the parquet version has to be aligned with What Spark uses in each Spark version. Otherwise there can be compatibility issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue:security issue:version-compatibility Version compatibility issues size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants