Skip to content

[WIP] optimization debian package manager tweaks#1400

Closed
rajpratik71 wants to merge 0 commit intoapache:masterfrom
AI-ML-Projects:master
Closed

[WIP] optimization debian package manager tweaks#1400
rajpratik71 wants to merge 0 commit intoapache:masterfrom
AI-ML-Projects:master

Conversation

@rajpratik71
Copy link

By default, Ubuntu or Debian based "apt" or "apt-get" system installs recommended but not suggested packages .

By passing "--no-install-recommends" option, the user lets apt-get know not to consider recommended packages as a dependency to install.

This results in smaller downloads and installation of packages .

Refer to blog at Ubuntu Blog .

Signed-off-by: Pratik Raj rajpratik71@gmail.com

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@codecov-io
Copy link

codecov-io commented Mar 12, 2020

Codecov Report

Merging #1400 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1400   +/-   ##
=========================================
  Coverage     67.50%   67.50%           
  Complexity      230      230           
=========================================
  Files           337      337           
  Lines         16354    16354           
  Branches       1671     1671           
=========================================
  Hits          11040    11040           
  Misses         4579     4579           
  Partials        735      735           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40a0d4...105cad1. Read the comment docs.

Copy link
Contributor

@bvaradar bvaradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajpratik71 : This part of the changes is not tested by automated integration tests as they rely on pre-build images. Can you build docker images using docker/build_local_docker_images.sh and manually run https://hudi.apache.org/docs/docker_demo.html to verify. Also, Please attach the logs of your testing in the PR. Thanks, Balaji.V

@vinothchandar
Copy link
Member

@rajpratik71 also please raise a JIRA for this work!

@bvaradar
Copy link
Contributor

@rajpratik71 : Just pinging to see if you are planning to work on this PR.

@rajpratik71
Copy link
Author

@rajpratik71 : Just pinging to see if you are planning to work on this PR.

will do , currently occupied.

@vinothchandar vinothchandar changed the title optimization debian package manager tweaks [WIP] optimization debian package manager tweaks May 14, 2020
@vinothchandar vinothchandar assigned lamberken and unassigned bvaradar May 14, 2020
@vinothchandar vinothchandar added the status:in-progress Work in progress label Oct 4, 2020
@rajpratik71 rajpratik71 closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:in-progress Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants