perf: Avoid materializing into intermediate list in metadata table path#14033
Merged
nsivabalan merged 1 commit intoapache:masterfrom Oct 3, 2025
Merged
Conversation
the-other-tim-brown
force-pushed
the
lazy-iter-to-stream
branch
from
1895b42 to
a2d5ec8
Compare
the-other-tim-brown
force-pushed
the
lazy-iter-to-stream
branch
from
a2d5ec8 to
408aed7
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
There is one path in the metadata table that is not properly leveraging iterators and needs a fix
Summary and Changelog
HoodieListDatathat takes in an iterator. This method will convert to a stream and add the proper hook to close the iterator if required.readSliceAndFilterByKeysIntoListto use the above constructorImpact
Avoids reading data into a list just to create an iterator
Risk Level
None
Documentation Update
Contributor's checklist