fix: Fixing record index related configs and enums#14180
Merged
bhasudha merged 4 commits intoapache:masterfrom Nov 5, 2025
Merged
fix: Fixing record index related configs and enums#14180bhasudha merged 4 commits intoapache:masterfrom
bhasudha merged 4 commits intoapache:masterfrom
Conversation
nsivabalan
force-pushed
the
partitionedRLI_Rename
branch
from
1aa75f5 to
6352a9b
Compare
yihua
reviewed
Oct 31, 2025
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
Show resolved
Hide resolved
| DataSourceWriteOptions.TABLE_TYPE.key -> HoodieTableType.MERGE_ON_READ.name(), | ||
| "hoodie.metadata.index.column.stats.enable" -> "false", | ||
| HoodieMetadataConfig.RECORD_INDEX_ENABLE_PROP.key -> "false") | ||
| HoodieMetadataConfig.GLOBAL_RECORD_LEVEL_INDEX_ENABLE_PROP.key -> "false") |
Contributor
There was a problem hiding this comment.
Could we also add a test with the old config naming to validate it works and prevents any breaking change in the future?
Contributor
Author
There was a problem hiding this comment.
I fixed one of the test to make it parametrized for this.
Contributor
Author
There was a problem hiding this comment.
nsivabalan
force-pushed
the
partitionedRLI_Rename
branch
from
9f5caa2 to
ba483f0
Compare
nsivabalan
commented
Nov 3, 2025
| "RECORD_INDEX", | ||
| "GLOBAL_RECORD_LEVEL_INDEX") | ||
| ) | ||
| // tests b/w compatibility of configs for global RLI |
Contributor
Author
There was a problem hiding this comment.
tests added for b/w compatibility
nsivabalan
commented
Nov 3, 2025
| "hoodie.metadata.record.index.enable", | ||
| "hoodie.metadata.global.record.level.index.enable") | ||
| ) | ||
| // tests b/w compatibility of configs for global RLI |
Contributor
Author
There was a problem hiding this comment.
tests added for b/w compatibility
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
Nov 10, 2025
* Fixing record index related configs and enums * Fixing compilation after rebase * Addressing feedback from Ethan * fixing compilation error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Standardize config names and enums related to record level index.
Index type (hoodie.index.type):
Prior to this patch:
RECORD_INDEX- > refers to global version of RLIPARTITIONED_RECORD_INDEX-> refers to non global version of RLIChange with this PR:
GLOBAL_RECORD_LEVEL_INDEX-> refers to global version of RLIRECORD_LEVEL_INDEX-> refers to non global version of RLIWriter property to enable for mdt writes:
Prior to this patch:
hoodie.metadata.record.index.enable-> enables global version of RLI with mdt writes.hoodie.metadata.partitioned.record.index.enable-> enables non global version of RLI with mdt writes.Change with this PR:
hoodie.metadata.global.record.level.index.enable-> enables global version of RLI with mdt writes.hoodie.metadata.record.level.index.enable-> enables non global version of RLI with mdt writes.Summary and Changelog
Switching index type of global version of RLI from
RECORD_INDEXtoGLOBAL_RECORD_LEVEL_INDEX. (Added b/w compatibilty support as well).Switching index type of non-global version of RLI from
PARTITIONED_RECORD_INDEXtoRECORD_LEVEL_INDEX.Switching writer property to enable global RLI with mdt writes from
hoodie.metadata.record.index.enabletohoodie.metadata.global.record.level.index.enable. Added b/w compatibility support as well.Switching writer property to enable non global RLI with mdt writes from
hoodie.metadata.partitioned.record.index.enabletohoodie.metadata.record.level.index.enable.Impact
Standard naming conventions in line with other indexes.
Risk Level
low.
Documentation Update
Contributor's checklist