test: Add validation on Spark SQL test classes and fix package structure#14381
Merged
yihua merged 4 commits intoapache:masterfrom Dec 13, 2025
Merged
test: Add validation on Spark SQL test classes and fix package structure#14381yihua merged 4 commits intoapache:masterfrom
yihua merged 4 commits intoapache:masterfrom
Conversation
4 tasks
fecdd97 to
83972bd
Compare
voonhous
reviewed
Nov 29, 2025
...rk-datasource/hudi-spark/src/test/java/org/apache/hudi/TestSparkSqlHudiPackageStructure.java
Outdated
Show resolved
Hide resolved
...-spark-common/src/test/scala/org/apache/spark/sql/hudi/common/TestProvidesHoodieConfig.scala
Show resolved
Hide resolved
voonhous
approved these changes
Nov 30, 2025
Member
voonhous
left a comment
There was a problem hiding this comment.
Comments addressed, LGTM.
Docs will be updated separately.
83972bd to
6b75fe9
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Some Spark SQL tests are not executed in CI.
Summary and Changelog
This PR enforces proper package structure for Spark SQL test classes under
org.apache.spark.sql.hudiby:org.apache.spark.sql.hudi.catalogto the allowed wildcard test suites in CI configurationorg.apache.spark.sql.huditoorg.apache.spark.sql.hudi.commonTestSparkSqlHudiPackageStructurewhich validates that Scala test classes underorg.apache.spark.sql.hudiare only in allowed packages.Impact
Fixes test coverage and adds validation to guarantee test coverage in the future.
Risk Level
none
Documentation Update
N/A
Contributor's checklist