Skip to content

test: Add validation on Spark SQL test classes and fix package structure#14381

Merged
yihua merged 4 commits intoapache:masterfrom
yihua:fix-spark-sql-test-package
Dec 13, 2025
Merged

test: Add validation on Spark SQL test classes and fix package structure#14381
yihua merged 4 commits intoapache:masterfrom
yihua:fix-spark-sql-test-package

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Nov 28, 2025

Describe the issue this Pull Request addresses

Some Spark SQL tests are not executed in CI.

Summary and Changelog

This PR enforces proper package structure for Spark SQL test classes under org.apache.spark.sql.hudi by:

  • Adds org.apache.spark.sql.hudi.catalog to the allowed wildcard test suites in CI configuration
  • Moves misplaced test classes from org.apache.spark.sql.hudi to org.apache.spark.sql.hudi.common
  • Fixes package declarations and imports in affected test files
  • Adds TestSparkSqlHudiPackageStructure which validates that Scala test classes under org.apache.spark.sql.hudi are only in allowed packages.

Impact

Fixes test coverage and adds validation to guarantee test coverage in the future.

Risk Level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Nov 28, 2025
@yihua yihua force-pushed the fix-spark-sql-test-package branch from fecdd97 to 83972bd Compare November 29, 2025 02:17
@apache apache deleted a comment from hudi-bot Nov 29, 2025
Copy link
Member

@voonhous voonhous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some nit comments.

Copy link
Member

@voonhous voonhous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed, LGTM.

Docs will be updated separately.

@yihua yihua force-pushed the fix-spark-sql-test-package branch from 83972bd to 6b75fe9 Compare December 13, 2025 19:23
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit 6eef695 into apache:master Dec 13, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M PR with lines of changes in (100, 300]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants