[HUDI-1000] Fix incremental query for COW non-partitioned table with no data#1708
Merged
leesf merged 4 commits intoapache:masterfrom Jun 8, 2020
Merged
[HUDI-1000] Fix incremental query for COW non-partitioned table with no data#1708leesf merged 4 commits intoapache:masterfrom
leesf merged 4 commits intoapache:masterfrom
Conversation
leesf
reviewed
Jun 6, 2020
| } | ||
| String incrementalInputPaths = partitionsToList.stream() | ||
| .map(s -> tableMetaClient.getBasePath() + Path.SEPARATOR + s) | ||
| .map(s -> "".equals(s) ? tableMetaClient.getBasePath() : tableMetaClient.getBasePath() + Path.SEPARATOR + s) |
Contributor
There was a problem hiding this comment.
"".equals(s) would be changed to StringUtils.isNullOrEmpty
Codecov Report
@@ Coverage Diff @@
## master #1708 +/- ##
=========================================
Coverage 18.19% 18.19%
Complexity 857 857
=========================================
Files 348 348
Lines 15358 15358
Branches 1525 1525
=========================================
Hits 2794 2794
Misses 12206 12206
Partials 358 358
Continue to review full report at Codecov.
|
leesf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix incremental query for COW non-partitioned table no data
jira url: https://issues.apache.org/jira/projects/HUDI/issues/HUDI-1000?filter=allopenissues