[HUDI-1005] fix NPE in HoodieWriteClient.clean

[shenh062326]

Tips

• Thank you very much for contributing to Apache Hudi.
• Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request

• Fix NPE in HoodieWriteClient.clean

Brief change log

(for example:)

• Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end.
• Added HoodieClientWriteTest to verify the change.
• Manually verified the change by running a job locally.

Committer checklist

• Has a corresponding JIRA in PR title & commit

• Commit message is descriptive of the change

• CI is green

• Necessary doc changes done or have another open PR

• For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.24%. Comparing base (fb28393) to head (5239c9e).
Report is 4707 commits behind head on master.

Files with missing lines	Patch %	Lines
...java/org/apache/hudi/client/HoodieWriteClient.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1714      +/-   ##
============================================
+ Coverage     18.19%   18.24%   +0.05%     
- Complexity      857      863       +6     
============================================
  Files           348      348              
  Lines         15358    15391      +33     
  Branches       1525     1525              
============================================
+ Hits           2794     2808      +14     
- Misses        12206    12225      +19     
  Partials        358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shenh062326]

@vinothchandar can you take a look at this?

[vinothchandar]

I was wondering if there was a way to just throw an exception or make it an Option.. merged.. let's punt on this for now

[shenh062326]

I was wondering if there was a way to just throw an exception or make it an Option.. merged.. let's punt on this for now

When I try to run HoodieDeltaStreamer with metrics on, it's no clean action in hoodie meta, then HoodieTable.create(config, hadoopConf).clean(jsc, cleanInstantTime) will return null.

hongdeMacBook-Pro hongshen$ ll .hoodie/
total 56
drwxr-xr-x  13 hongshen  wheel   416 Jun 10 10:11 ./
drwxr-xr-x   4 hongshen  wheel   128 Jun 10 10:11 ../
-rw-r--r--   1 hongshen  wheel    32 Jun 10 10:11 .20200610101112.commit.crc
-rw-r--r--   1 hongshen  wheel     8 Jun 10 10:11 .20200610101112.commit.requested.crc
-rw-r--r--   1 hongshen  wheel    12 Jun 10 10:11 .20200610101112.inflight.crc
drwxr-xr-x   2 hongshen  wheel    64 Jun 10 10:11 .aux/
-rw-r--r--   1 hongshen  wheel    12 Jun 10 10:11 .hoodie.properties.crc
drwxr-xr-x   2 hongshen  wheel    64 Jun 10 10:11 .temp/
-rw-r--r--   1 hongshen  wheel  2676 Jun 10 10:11 20200610101112.commit
-rw-r--r--   1 hongshen  wheel     0 Jun 10 10:11 20200610101112.commit.requested
-rw-r--r--   1 hongshen  wheel   380 Jun 10 10:11 20200610101112.inflight
drwxr-xr-x   2 hongshen  wheel    64 Jun 10 10:11 archived/
-rw-r--r--   1 hongshen  wheel   205 Jun 10 10:11 hoodie.properties