[WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…

[yui2010]

…BasedKeyGenerator

Tips

• Thank you very much for contributing to Apache Hudi.
• Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

• Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end.
• Added HoodieClientWriteTest to verify the change.
• Manually verified the change by running a job locally.

Committer checklist

• Has a corresponding JIRA in PR title & commit

• Commit message is descriptive of the change

• CI is green

• Necessary doc changes done or have another open PR

• For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

[yui2010]

1. in TimestampBasedKeyGenerator#getKey method, generate a HoodieKey will create a new SimpleDateFormat Object,the dateformat object can be reused as Class variable
2. SimpleDateFormat is not thread safe,there is always potential thread safe problem

[leesf]

@yui2010 Thanks for your contributing, would you please check the travis error?

[wangxianghu]

@yui2010 checkstyle issue, you can setup your IDE with style files from here : https://hudi.apache.org/contributing#ide-setup

[vinothchandar]

This is bringing back commons Lang:(

[vinothchandar]

We solved a ton of bundle conflicts for commons lang and no longer use it in the project. Please rework or without requiring it

[pratyakshsharma]

@leesf we no longer use SimpleDateFormat in TimestampBasedKeyGenerator. So the issues linked with usage of SimpleDateFormat are also no longer there. Guess we can close this?

[leesf]

@leesf we no longer use SimpleDateFormat in TimestampBasedKeyGenerator. So the issues linked with usage of SimpleDateFormat are also no longer there. Guess we can close this?

sure, @yui2010 please reopen if you have the issue again.