Skip to content

refactor: Apply lombok annotations and remove boilerplate code to hudi-client-c…#17524

Merged
voonhous merged 5 commits intoapache:masterfrom
voonhous:hudi-client-common-lombokify
Dec 13, 2025
Merged

refactor: Apply lombok annotations and remove boilerplate code to hudi-client-c…#17524
voonhous merged 5 commits intoapache:masterfrom
voonhous:hudi-client-common-lombokify

Conversation

@voonhous
Copy link
Member

@voonhous voonhous commented Dec 8, 2025

ommon

Describe the issue this Pull Request addresses

This PR refactors the hudi-client-common module to reduce boilerplate code by leveraging Project Lombok annotations. Specifically, it replaces explicit Logger instantiation, manual getter/setter methods, and empty constructors with their equivalent Lombok annotations (@Slf4j, @Getter, @Setter,@NoArgsConstructor, @AllArgsConstructor, @Data, @Value, @ToString).

This improves code readability and maintainability without altering the runtime logic.

Summary and Changelog

This change introduces the Lombok dependency to the hudi-client-common module and refactors several classes to utilize Lombok annotations.

  • Added lombok annotations wherever possible to hudi-client-common module.

Impact

  • Public API: None.
  • User Experience: No visible change for end-users.
  • Performance: No impact (compile-time code generation).
  • Code Health: Reduces lines of code and standardizes logging/accessor patterns.

Risk Level

none

(This is a pure refactoring change involving standard library annotations; no business logic was modified.)

Documentation Update

none

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@github-actions github-actions bot added the size:XL PR with lines of changes > 1000 label Dec 8, 2025
@voonhous voonhous force-pushed the hudi-client-common-lombokify branch from bda857b to aed438b Compare December 8, 2025 15:45
@voonhous voonhous requested a review from yihua December 8, 2025 15:45
@voonhous voonhous force-pushed the hudi-client-common-lombokify branch from aed438b to aaff385 Compare December 8, 2025 16:19
@voonhous voonhous force-pushed the hudi-client-common-lombokify branch 2 times, most recently from 6f1052a to 8dcca31 Compare December 9, 2025 04:29
@voonhous voonhous force-pushed the hudi-client-common-lombokify branch 2 times, most recently from 24925f1 to 75a05bb Compare December 9, 2025 08:08
@voonhous voonhous self-assigned this Dec 9, 2025
@voonhous
Copy link
Member Author

voonhous commented Dec 11, 2025

@yihua CI is passing, can you please give it another round of review?

@voonhous voonhous force-pushed the hudi-client-common-lombokify branch from 5cf4264 to d9d4558 Compare December 12, 2025 11:41
@voonhous voonhous force-pushed the hudi-client-common-lombokify branch from d9d4558 to f9037af Compare December 13, 2025 06:44
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@voonhous
Copy link
Member Author

image

CI Green, merging this PR in.

@voonhous voonhous merged commit 9f4be6d into apache:master Dec 13, 2025
70 checks passed
@voonhous voonhous deleted the hudi-client-common-lombokify branch December 13, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL PR with lines of changes > 1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants