refactor: Apply lombok annotations and remove boilerplate code to hudi-client-c…#17524
Merged
voonhous merged 5 commits intoapache:masterfrom Dec 13, 2025
Merged
Conversation
bda857b to
aed438b
Compare
aed438b to
aaff385
Compare
yihua
reviewed
Dec 8, 2025
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/SecondaryIndexStats.java
Outdated
Show resolved
Hide resolved
yihua
reviewed
Dec 8, 2025
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/TableWriteStats.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java
Outdated
Show resolved
Hide resolved
yihua
reviewed
Dec 8, 2025
...hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java
Show resolved
Hide resolved
...-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/BloomIndexFileInfo.java
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/KeyRangeNode.java
Outdated
Show resolved
Hide resolved
6f1052a to
8dcca31
Compare
voonhous
commented
Dec 9, 2025
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
Outdated
Show resolved
Hide resolved
24925f1 to
75a05bb
Compare
Member
Author
|
@yihua CI is passing, can you please give it another round of review? |
5cf4264 to
d9d4558
Compare
yihua
reviewed
Dec 13, 2025
...hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java
Show resolved
Hide resolved
yihua
reviewed
Dec 13, 2025
...t/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/OperationResult.java
Show resolved
Hide resolved
yihua
reviewed
Dec 13, 2025
...lient/hudi-client-common/src/main/java/org/apache/hudi/table/action/HoodieWriteMetadata.java
Show resolved
Hide resolved
...lient/hudi-client-common/src/main/java/org/apache/hudi/table/action/HoodieWriteMetadata.java
Show resolved
Hide resolved
yihua
reviewed
Dec 13, 2025
...-client-common/src/test/java/org/apache/hudi/client/heartbeat/TestHoodieHeartbeatClient.java
Outdated
Show resolved
Hide resolved
d9d4558 to
f9037af
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ommon
Describe the issue this Pull Request addresses
This PR refactors the
hudi-client-commonmodule to reduce boilerplate code by leveraging Project Lombok annotations. Specifically, it replaces explicitLoggerinstantiation, manual getter/setter methods, and empty constructors with their equivalent Lombok annotations (@Slf4j,@Getter,@Setter,@NoArgsConstructor,@AllArgsConstructor,@Data,@Value,@ToString).This improves code readability and maintainability without altering the runtime logic.
Summary and Changelog
This change introduces the Lombok dependency to the
hudi-client-commonmodule and refactors several classes to utilize Lombok annotations.hudi-client-commonmodule.Impact
Risk Level
none
(This is a pure refactoring change involving standard library annotations; no business logic was modified.)
Documentation Update
none
Contributor's checklist