refactor: Add Lombok annotations to hudi-java-client module#17588
Merged
yihua merged 2 commits intoapache:masterfrom Dec 16, 2025
Merged
refactor: Add Lombok annotations to hudi-java-client module#17588yihua merged 2 commits intoapache:masterfrom
yihua merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
@CTTY Could you review this PR? |
Member
Author
|
Nothing much to change in this, they are mainly just |
CTTY
reviewed
Dec 14, 2025
Contributor
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
LGTM in general! Only some minor comments
| import org.junit.jupiter.params.provider.MethodSource; | ||
| import org.junit.jupiter.params.provider.ValueSource; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; |
Contributor
There was a problem hiding this comment.
Should we remove the LoggerFactory as well?
Member
Author
There was a problem hiding this comment.
Good catch! Thought i removed all of them T.T.
Addressed!
| final String instantTime, final Map<String, String> strategyParams, final Schema schema, | ||
| final List<HoodieFileGroupId> fileGroupIdList, final boolean preserveHoodieMetadata) { | ||
| LOG.info("Starting clustering for a group, parallelism:" + numOutputGroups + " commit:" + instantTime); | ||
| log.info("Starting clustering for a group, parallelism:" + numOutputGroups + " commit:" + instantTime); |
Contributor
There was a problem hiding this comment.
nit: it would be better if we just go with parameterized logging:
log.info("Starting clustering for a group, parallelism:{} commit:{}", numOutputGroups, instantTime);
Member
Author
There was a problem hiding this comment.
Yeap, definitely!
Addressed!
voonhous
force-pushed
the
hudi-java-client-lomokify
branch
from
a7cb6e1 to
fddad56
Compare
Collaborator
CTTY
approved these changes
Dec 15, 2025
Contributor
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
LGTM! There are many other loggings that can be parameterized, but I don't think they should block this PR
yihua
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
This PR refactors the
hudi-java-clientmodule to reduce boilerplate code by leveraging Project Lombok annotations. Specifically, it replaces explicitLoggerinstantiation, manual getter/setter methods, and empty constructors with their equivalent Lombok annotations (@Slf4j,@Getter,@Setter,@NoArgsConstructor,@AllArgsConstructor,@Data,@Value,@ToString).This improves code readability and maintainability without altering the runtime logic.
Summary and Changelog
This change introduces the Lombok dependency to the
hudi-java-clientmodule and refactors several classes to utilize Lombok annotations.hudi-java-clientmodule.Impact
Risk Level
none
(This is a pure refactoring change involving standard library annotations; no business logic was modified.)
Documentation Update
none
Contributor's checklist