refactor: Add Lombok annotations to hudi-integ-test module#17667
Merged
yihua merged 2 commits intoapache:masterfrom Dec 23, 2025
Merged
refactor: Add Lombok annotations to hudi-integ-test module#17667yihua merged 2 commits intoapache:masterfrom
yihua merged 2 commits intoapache:masterfrom
Conversation
yihua
reviewed
Dec 23, 2025
|
|
||
| public Pair<Integer, JavaRDD<DeltaWriteStats>> writeRecords(JavaRDD<GenericRecord> records) { | ||
| if (deltaOutputConfig.shouldDeleteOldInputData() && batchId > 1) { | ||
| if (deltaOutputConfig.isShouldDeleteOldInputData() && batchId > 1) { |
Contributor
There was a problem hiding this comment.
isShouldDeleteOldInputData: the name does not read well. Could it be renamed to isOldInputDataDeleted based on oldInputDataDeleted?
Member
Author
There was a problem hiding this comment.
Sure, let me rename it!
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
This PR refactors the
hudi-integ-testmodule to reduce boilerplate code by leveraging Project Lombok annotations. Specifically, it replaces explicitLoggerinstantiation, manual getter/setter methods, and empty constructors with their equivalent Lombok annotations (@Slf4j,@Getter,@Setter,@NoArgsConstructor,@AllArgsConstructor,@Data,@Value,@ToString).This improves code readability and maintainability without altering the runtime logic.
Summary and Changelog
This change introduces the Lombok dependency to the
hudi-integ-testmodule and refactors several classes to utilize Lombok annotations.hudi-integ-testmodule.Impact
Risk Level
none
(This is a pure refactoring change involving standard library annotations; no business logic was modified.)
Documentation Update
none
Contributor's checklist