refactor: Add Lombok Builder annotation to TimelineService.Config

[voonhous]

Describe the issue this Pull Request addresses

Adding Lombok Builder annotation to TimelineService.Config to remove boilerplate code.

Summary and Changelog

1. Added Lombok Builder annotation to TimelineService.Config
2. Removed boilerplate code
3. Updated naming of configs to make it more consistent across WriteConfig and TimelineService.Config

Impact

None

Risk Level

None

Documentation Update

None

Contributor's checklist

• Read through contributor's guide
• Enough context is provided in the sections above
• Adequate tests were added if applicable

[hudi-bot]

CI report:

• 41f1420 Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build

[danny0405]

the prefix "earlyConflictDetection" is removed?

[voonhous]

earlyConflictDetectionMaxAllowableHeartbeatIntervalInMs > maxAllowableHeartbeatIntervalInMs.

public Builder earlyConflictDetectionMaxAllowableHeartbeatIntervalInMs(Long maxAllowableHeartbeatIntervalInMs) {
        this.maxAllowableHeartbeatIntervalInMs = maxAllowableHeartbeatIntervalInMs;
        return this;
      }

[danny0405]

should we rename the maxAllowableHeartbeatIntervalInMs too to make the API unchanged.

[voonhous]

The original code uses maxAllowableHeartbeatIntervalInMs almost everywhere. The only place where this config was renamed is in the builder interface. Which is only used in 2 locations:

I am in favour of keeping maxAllowableHeartbeatIntervalInMs so the entire code base is more consistent as majority is using maxAllowableHeartbeatIntervalInMs.

[danny0405]

okay, sounds fair.

[danny0405]

+1