[HUDI-994] Split TestHBaseIndex to unit tests #1818
[HUDI-994] Split TestHBaseIndex to unit tests #1818vinothchandar merged 2 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
moved to a separate unit test class
There was a problem hiding this comment.
duplicate test case in org.apache.hudi.index.hbase.TestHBaseQPSResourceAllocator
There was a problem hiding this comment.
moved to a separate unit test class
xushiyan
changed the title
|
@vinothchandar this is ready for review. Thanks. |
yanghua
left a comment
yanghua
left a comment
There was a problem hiding this comment.
About the changes LGTM. Some minor suggestions:
- The title of PR did not align with the Jira issue and can not describe all the changes in this PR;
- This PR contains refactor about TestHBaseIndex, code cleanup, some optimization(reduce generated number of records), and so on. IMO, we should split these kinds of work into different PRs in the future.
vinothchandar
left a comment
vinothchandar
left a comment
There was a problem hiding this comment.
Just 1 comment..
+1 to @yanghua 's suggestion. Not sure if splitting into different PRs is warranted but having a more pertinent title helps!
There was a problem hiding this comment.
its not very clear what a sub path stands for? rename to make it clearer?
There was a problem hiding this comment.
ok remove this api.. not used at the moment.
|
@yanghua @vinothchandar Thanks for the review. I can split the changes into 2 PRs
going to work on this in next few hours... |
xushiyan
force-pushed
the
functional-tests-for-clients
branch
from
6ff2cc1 to
8ab22ab
Compare
Split done. The 2nd one goes to #1824 , which contains the commit in this PR. Please take another pass. Thanks. |
xushiyan
changed the title
- Refactor and improve TestHBaseIndex for performance - Move HBaseIndex unit tests to different test classes
xushiyan
force-pushed
the
functional-tests-for-clients
branch
from
8ab22ab to
6352eef
Compare
3 participants
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.