fix: Fail metadata bootstrap early in presence of 0 byte file#18209
Open
suryaprasanna wants to merge 3 commits intoapache:masterfrom
Open
fix: Fail metadata bootstrap early in presence of 0 byte file#18209suryaprasanna wants to merge 3 commits intoapache:masterfrom
suryaprasanna wants to merge 3 commits intoapache:masterfrom
Conversation
nsivabalan
approved these changes
Feb 19, 2026
e9e8f2d to
dd1a076
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
This PR addresses an issue where metadata bootstrap can fail silently or with unclear errors when encountering 0-byte base files in the table. During metadata table rebootstrap, especially with record-level index enabled, the presence of empty files can lead to corruption and unclear error messages. This change adds early validation to detect and report such issues with clear context.
Summary and Changelog
Users will now get a clear, early failure message when metadata bootstrap encounters a 0-byte file, making debugging easier and preventing silent corruption.
Changes:
HoodieMetadataPayload.javato check that files being added have positive sizetestRecordIndexRebootstrapWithZeroByteBaseFileinTestRecordLevelIndex.scalathat:Impact
User-facing impact: Users will receive clearer error messages when metadata operations encounter 0-byte files, making debugging significantly easier.
API changes: None
Performance impact: Minimal - adds a single size check during metadata bootstrap.
Risk Level
Low - This change only adds validation to fail fast on already corrupt/invalid state. It does not change any successful code paths. The validation prevents proceeding with corrupt data that would fail later with unclear errors.
Verification:
Documentation Update
None - this is an internal validation improvement that doesn't introduce new configs or user-facing features.
Contributor's checklist