refactor: Remove not used classes from org.apache.hudi.spark.internal#18211
Merged
wombatu-kun merged 1 commit intoapache:masterfrom Feb 17, 2026
Merged
Conversation
org.apache.hudi.spark.internal
Contributor
Author
|
|
Collaborator
wombatu-kun
approved these changes
Feb 17, 2026
Contributor
|
nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
#2328 added support of bulk insert using DSv2 for Spark 3.0 at 2020.
Later #8076 added support of bulk insert for insert overwrite (table) by
in
DatasetBulkInsertCommitActionExecutor, which callsorg.apache.hudi.spark3.internal.DefaultSource.#13301 moved the code from hudi-spark3-common to hudi-spark-common module.
And then #13360 unified code paths, and switched bulk insert to call of
HoodieDatasetBulkInsertHelper::bulkInsertwithout call oforg.apache.hudi.spark.internal.So, there is no internal calls of
org.apache.hudi.spark.internalclasses anymore. And all the following pack of classes could be removed:Summary and Changelog
Removes classes in
org.apache.hudi.spark.internalthat are not used anymore.Impact
No impact. First, they are named as internal. Second, there is no
.../META-INF/services/org.apache.spark.sql.sources.DataSourceRegisterfiles, which callsorg.apache.hudi.spark.internal.*. This means that users couldn't call those classes.Risk Level
None
Documentation Update
None
Contributor's checklist