fix: Remove trailing colon from incomplete error message in HoodieTableMetadataUtil#18233
Open
shangxinli wants to merge 1 commit intoapache:masterfrom
Open
fix: Remove trailing colon from incomplete error message in HoodieTableMetadataUtil#18233shangxinli wants to merge 1 commit intoapache:masterfrom
shangxinli wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18233 +/- ##
=========================================
Coverage 57.28% 57.28%
- Complexity 18532 18535 +3
=========================================
Files 1944 1944
Lines 106126 106126
Branches 13118 13118
=========================================
+ Hits 60793 60797 +4
Misses 39610 39610
+ Partials 5723 5719 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
The exception message in
HoodieTableMetadataUtil.deleteMetadataTablePartition()ends with a trailing:which appears incomplete and looks like a formatting artifact.Summary and Changelog
Summary:
Remove the trailing
:from the error message inHoodieTableMetadataUtilwhen failing to check existence of a metadata table partition.Changelog:
"Failed to check existence of MDT partition %s at path %s: "to"Failed to check existence of MDT partition %s at path %s"inHoodieTableMetadataUtil.java:2259. The cause exception is already passed as the second argument toHoodieMetadataException, so the trailing colon adds no value.Impact
Public API Changes:
None.
User-Facing Changes:
Slightly cleaner error message when metadata table partition check fails.
Performance Impact:
None.
Risk Level
Risk Level: low
Justification:
Documentation Update
No documentation changes needed.
Contributor's checklist