Skip to content

Comments

fix: Remove trailing colon from incomplete error message in HoodieTableMetadataUtil#18233

Open
shangxinli wants to merge 1 commit intoapache:masterfrom
shangxinli:fix-incomplete-error-message
Open

fix: Remove trailing colon from incomplete error message in HoodieTableMetadataUtil#18233
shangxinli wants to merge 1 commit intoapache:masterfrom
shangxinli:fix-incomplete-error-message

Conversation

@shangxinli
Copy link
Contributor

Describe the issue this Pull Request addresses

The exception message in HoodieTableMetadataUtil.deleteMetadataTablePartition() ends with a trailing : which appears incomplete and looks like a formatting artifact.

Summary and Changelog

Summary:
Remove the trailing : from the error message in HoodieTableMetadataUtil when failing to check existence of a metadata table partition.

Changelog:

  • Changed "Failed to check existence of MDT partition %s at path %s: " to "Failed to check existence of MDT partition %s at path %s" in HoodieTableMetadataUtil.java:2259. The cause exception is already passed as the second argument to HoodieMetadataException, so the trailing colon adds no value.

Impact

Public API Changes:
None.

User-Facing Changes:
Slightly cleaner error message when metadata table partition check fails.

Performance Impact:
None.

Risk Level

Risk Level: low

Justification:

  • Single character removal in an error message string
  • No logic changes
  • The root cause exception is already chained via the constructor

Documentation Update

No documentation changes needed.

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable
  • Commits are signed and follow conventions

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Feb 22, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.28%. Comparing base (057af9e) to head (5a8b2ed).

Files with missing lines Patch % Lines
.../apache/hudi/metadata/HoodieTableMetadataUtil.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #18233   +/-   ##
=========================================
  Coverage     57.28%   57.28%           
- Complexity    18532    18535    +3     
=========================================
  Files          1944     1944           
  Lines        106126   106126           
  Branches      13118    13118           
=========================================
+ Hits          60793    60797    +4     
  Misses        39610    39610           
+ Partials       5723     5719    -4     
Flag Coverage Δ
hadoop-mr-java-client 45.37% <0.00%> (-0.04%) ⬇️
spark-java-tests 47.43% <0.00%> (+<0.01%) ⬆️
spark-scala-tests 45.51% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../apache/hudi/metadata/HoodieTableMetadataUtil.java 77.00% <0.00%> (-0.08%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS PR with lines of changes in <= 10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants