fix: Fix string handling on bloom index Metadata Payload#18240
Merged
wombatu-kun merged 1 commit intoapache:masterfrom Feb 24, 2026
Merged
fix: Fix string handling on bloom index Metadata Payload#18240wombatu-kun merged 1 commit intoapache:masterfrom
wombatu-kun merged 1 commit intoapache:masterfrom
Conversation
Comment on lines
+147
to
+148
| bloomFilterRecord.get(BLOOM_FILTER_FIELD_TYPE).toString(), | ||
| bloomFilterRecord.get(BLOOM_FILTER_FIELD_TIMESTAMP).toString(), |
Contributor
Author
There was a problem hiding this comment.
Both of these are required fields in the schema so there is no null check
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18240 +/- ##
============================================
- Coverage 61.43% 57.27% -4.16%
+ Complexity 23082 18533 -4549
============================================
Files 2108 1944 -164
Lines 127636 106132 -21504
Branches 14534 13118 -1416
============================================
- Hits 78409 60791 -17618
+ Misses 42873 39620 -3253
+ Partials 6354 5721 -633
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
wombatu-kun
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Fixes a potential issue where strings can be UTF8 String in GenericRecord. This was handled for other payloads but not the bloom filter payload.
Summary and Changelog
Uses
toStringinstead of castingImpact
Fixes potential runtime issue
Risk Level
Low
Documentation Update
Contributor's checklist