Skip to content

fix: Fix string handling on bloom index Metadata Payload#18240

Merged
wombatu-kun merged 1 commit intoapache:masterfrom
the-other-tim-brown:minor-string-handling
Feb 24, 2026
Merged

fix: Fix string handling on bloom index Metadata Payload#18240
wombatu-kun merged 1 commit intoapache:masterfrom
the-other-tim-brown:minor-string-handling

Conversation

@the-other-tim-brown
Copy link
Contributor

@the-other-tim-brown the-other-tim-brown commented Feb 23, 2026

Describe the issue this Pull Request addresses

Fixes a potential issue where strings can be UTF8 String in GenericRecord. This was handled for other payloads but not the bloom filter payload.

Summary and Changelog

Uses toString instead of casting

Impact

Fixes potential runtime issue

Risk Level

Low

Documentation Update

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@the-other-tim-brown the-other-tim-brown changed the title bug: Fix string handling on bloom index Metadata Payload fix: Fix string handling on bloom index Metadata Payload Feb 23, 2026
Comment on lines +147 to +148
bloomFilterRecord.get(BLOOM_FILTER_FIELD_TYPE).toString(),
bloomFilterRecord.get(BLOOM_FILTER_FIELD_TIMESTAMP).toString(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these are required fields in the schema so there is no null check

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Feb 23, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.27%. Comparing base (ec04479) to head (a9a39e8).
⚠️ Report is 988 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18240      +/-   ##
============================================
- Coverage     61.43%   57.27%   -4.16%     
+ Complexity    23082    18533    -4549     
============================================
  Files          2108     1944     -164     
  Lines        127636   106132   -21504     
  Branches      14534    13118    -1416     
============================================
- Hits          78409    60791   -17618     
+ Misses        42873    39620    -3253     
+ Partials       6354     5721     -633     
Flag Coverage Δ
hadoop-mr-java-client 45.41% <0.00%> (?)
spark-java-tests 47.43% <100.00%> (?)
spark-scala-tests 45.51% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rg/apache/hudi/metadata/MetadataPartitionType.java 71.02% <100.00%> (ø)

... and 4008 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@wombatu-kun wombatu-kun merged commit 18ee6cd into apache:master Feb 24, 2026
73 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS PR with lines of changes in <= 10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants