refactor: remove HoodieWriteConfig.getOrcCompressionCodec() function#18422
Merged
danny0405 merged 1 commit intoapache:masterfrom Mar 31, 2026
Merged
Conversation
skywalker0618
changed the title
Collaborator
danny0405
approved these changes
Mar 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18422 +/- ##
============================================
- Coverage 68.26% 68.25% -0.01%
+ Complexity 27761 27760 -1
============================================
Files 2439 2439
Lines 134355 134354 -1
Branches 16210 16210
============================================
- Hits 91715 91709 -6
- Misses 35543 35548 +5
Partials 7097 7097
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Current hudi 1.2 streaming source has a hard dependency on orc due to function HoodieWriteConfig.getOrcCompressionCodec() returns an ORC class. As this function is not used, we can safely remove it so that the hudi 1.2 won't have a hard dependency on orc.
Fixes #18397
Summary and Changelog
Remove HoodieWriteConfig.getOrcCompressionCodec() function
Impact
None
Risk Level
None
Documentation Update
None
Contributor's checklist