chore(docker): fix Hadoop entrypoint.sh property bugs in all base modules#18527
Merged
Merged
Conversation
…int.sh - The property was inserted into yarn-site.xml twice with the same value in the MULTIHOMED_NETWORK=1 block. - Duplicates are harmless at runtime (Hadoop's Configuration parser takes the last value for duplicates and both writes use the same value), but the second write is dead code. - Applies to base, base_java11, and base_java17.
voonhous
force-pushed
the
fix-hadoop-entrypoint-bugs
branch
from
01fa6e3 to
706eb1a
Compare
voonhous
changed the title
github-actions
Bot
added
size:XS
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18527 +/- ##
============================================
+ Coverage 68.87% 68.88% +0.01%
- Complexity 28272 28279 +7
============================================
Files 2464 2464
Lines 135594 135594
Branches 16447 16447
============================================
+ Hits 93389 93404 +15
+ Misses 34815 34807 -8
+ Partials 7390 7383 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
hudi-agent
reviewed
Apr 19, 2026
Contributor
hudi-agent
left a comment
hudi-agent
left a comment
There was a problem hiding this comment.
🤖 This review was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.
No reviewable code files in this PR.
cc @yihua
danny0405
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
In
docker/hoodie/hadoop/*/entrypoint.sh, theMULTIHOMED_NETWORK=1block calls:addPropertyusessedto insert a new<property>block before</configuration>, so the same property ends up in the XML twice. Hadoop'sConfigurationparser tolerates duplicate names (last one wins) and both writes use the same value, so there is no runtime impact - but the second line is dead code and inconsistent with the rest of the block. This duplication was inherited from the upstreambig-data-europe/docker-hadooptemplate and propagated whenbase_java11andbase_java17were copied frombase.Summary and Changelog
addProperty /etc/hadoop/yarn-site.xml yarn.nodemanager.bind-host 0.0.0.0line from the YARN block in each of the three base modules'entrypoint.sh.Impact
None. Observable runtime behaviour is identical.
Risk Level
none, three-line deletion across three scripts, no functional change.
low - the change is six lines across three scripts, guarded by
MULTIHOMED_NETWORK=1. Before the fix the misplaced YARN property did nothing inmapred-site.xml, after the fix the correct JobHistory properties are written.No behavior change for the default, non-multi-homed case.
Documentation Update
None.
Contributor's checklist