Skip to content

fix: use KeyBasedFileGroupRecordBuffer for non-Parquet base files in MOR merge #18588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yihua wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −25
Open

fix: use KeyBasedFileGroupRecordBuffer for non-Parquet base files in MOR merge #18588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 12 additions & 25 deletions ...datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestLanceDataSource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,16 +1174,13 @@ class TestLanceDataSource extends HoodieSparkClientTestBase {
)

// Test 5: DELETE a row
// TODO(#18558): test DELETE with MOR table type once the bug is fixed
if (tableType == HoodieTableType.COPY_ON_WRITE) {
spark.sql(s"delete from $tableName where id = 3")
spark.sql(s"delete from $tableName where id = 3")

checkAnswer(s"select id, name, age, score, dt from $tableName order by id")(
Seq(1, "Alice", 31, 99.9, "2025-01-01"),
Seq(2, "Bob", 25, 87.3, "2025-01-02"),
Seq(4, "Diana", 40, null, "2025-01-01")
)
}
checkAnswer(s"select id, name, age, score, dt from $tableName order by id")(
Seq(1, "Alice", 31, 99.9, "2025-01-01"),
Seq(2, "Bob", 25, 87.3, "2025-01-02"),
Seq(4, "Diana", 40, null, "2025-01-01")
)

// Test 6: INSERT with static partition (only for partitioned tables)
if (isPartitioned) {
Expand All @@ -1192,22 +1189,12 @@ class TestLanceDataSource extends HoodieSparkClientTestBase {
values (28, 5, 'Eve')
""".stripMargin)

if (tableType == HoodieTableType.COPY_ON_WRITE) {
checkAnswer(s"select id, name, age, score, dt from $tableName order by id")(
Seq(1, "Alice", 31, 99.9, "2025-01-01"),
Seq(2, "Bob", 25, 87.3, "2025-01-02"),
Seq(4, "Diana", 40, null, "2025-01-01"),
Seq(5, "Eve", 28, null, "2025-01-05")
)
} else {
checkAnswer(s"select id, name, age, score, dt from $tableName order by id")(
Seq(1, "Alice", 31, 99.9, "2025-01-01"),
Seq(2, "Bob", 25, 87.3, "2025-01-02"),
Seq(3, "Charlie", 35, 92.1, "2025-01-02"),
Seq(4, "Diana", 40, null, "2025-01-01"),
Seq(5, "Eve", 28, null, "2025-01-05")
)
}
checkAnswer(s"select id, name, age, score, dt from $tableName order by id")(
Seq(1, "Alice", 31, 99.9, "2025-01-01"),
Seq(2, "Bob", 25, 87.3, "2025-01-02"),
Seq(4, "Diana", 40, null, "2025-01-01"),
Seq(5, "Eve", 28, null, "2025-01-05")
)
}

// Verify Lance files were created
Expand Down
Loading