chore(docker): silence Dockerfile lint warnings across image set#18664
Merged
Conversation
Three classes of buildkit warnings are addressed in the Hudi docker tree:
- LegacyKeyValueFormat: rewrite all `ENV KEY VALUE` to `ENV KEY=VALUE`
across 13 Dockerfiles. Quoted values and ${VAR} expansion preserved.
- UndefinedVar: re-declare HADOOP_DN_PORT, HADOOP_WEBHDFS_PORT, and
HADOOP_HISTORY_PORT as ARG after the FROM line in datanode, namenode,
and historyserver. Pre-FROM ARGs do not propagate into the build stage,
so the corresponding ENV expansions were silently empty.
- JSONArgsRecommended: change `CMD startup.sh` to `CMD ["startup.sh"]`
in hive_base so SIGTERM is delivered to the script directly instead of
through a /bin/sh -c wrapper.
No runtime behavior change beyond the metastore/hiveserver now receiving
shutdown signals correctly.
hudi-agent
reviewed
Apr 30, 2026
hudi-agent
left a comment
hudi-agent
left a comment
Contributor
There was a problem hiding this comment.
🤖 This review was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.
No reviewable code files in this PR.
cc @yihua
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18664 +/- ##
============================================
+ Coverage 68.06% 69.13% +1.07%
- Complexity 28922 32101 +3179
============================================
Files 2518 2548 +30
Lines 140574 153878 +13304
Branches 17419 20520 +3101
============================================
+ Hits 95682 106384 +10702
- Misses 37036 39104 +2068
- Partials 7856 8390 +534
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
danny0405
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
BuildKit emits three classes of lint warnings across the Hudi
docker/tree. Two of them are real bugs (silent empty env vars, signal-handling), the third is style:LegacyKeyValueFormat:ENV KEY VALUEform is deprecated.UndefinedVar: pre-FROMARGs do not carry into the build stage, soENV HADOOP_DN_PORT ${HADOOP_DN_PORT}etc. expanded to empty strings.JSONArgsRecommended:CMD startup.shruns through/bin/sh -c, which swallows SIGTERM and breaks graceful shutdown of the metastore/hiveserver.Summary and Changelog
ENV KEY VALUEtoENV KEY=VALUEacross 13 Dockerfiles. Quoted values and${VAR}expansion are preserved.HADOOP_DN_PORT,HADOOP_WEBHDFS_PORT, andHADOOP_HISTORY_PORTasARGafter theFROMline indatanode,namenode, andhistoryserver, so the correspondingENVexpansions actually receive the build-arg values.hive_base: switchCMD startup.shto JSON-array formCMD ["startup.sh"]so SIGTERM is delivered directly to the script.ARG HADOOP_VERSIONlines.Files touched:
base,base_java11,base_java17,datanode,historyserver,hive_base,namenode,prestobase,spark_base,sparkadhoc,sparkmaster,sparkworker,trinobase.Impact
HADOOP_DN_PORT/HADOOP_WEBHDFS_PORT/HADOOP_HISTORY_PORTenv vars are now populated from the corresponding ARGs (default values unchanged: 50075 / 50070 / 8188)./bin/sh -c, sodocker stopshuts them down cleanly.Risk Level
low. Docker build only. The behavior changes (env var population, signal delivery) are corrections, not new features, and defaults match prior intent.
Documentation Update
none.
Contributor's checklist