fix(lance): auto-infer DefaultSparkRecordMerger for Lance base file f…#18682
Draft
rahil-c wants to merge 1 commit intoapache:masterfrom
Draft
fix(lance): auto-infer DefaultSparkRecordMerger for Lance base file f…#18682rahil-c wants to merge 1 commit intoapache:masterfrom
rahil-c wants to merge 1 commit intoapache:masterfrom
Conversation
…ormat Lance is Spark-only and its writer/reader only handles Spark InternalRow, not Avro. When users create a Hudi table with Lance base file format, they currently must manually set hoodie.datasource.write.record.merger.impls to DefaultSparkRecordMerger. Without this config the write path falls back to HoodieAvroRecordMerger (the global default), which is incompatible with Lance's Arrow/columnar data format. Auto-inject DefaultSparkRecordMerger in HoodieSparkSqlWriter's mergeParamsAndGetHoodieConfig when BASE_FILE_FORMAT is LANCE and the user hasn't explicitly set RECORD_MERGE_IMPL_CLASSES. This covers all Spark write paths (DataFrame API, Spark SQL, structured streaming) and respects any explicit user override. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18682 +/- ##
============================================
- Coverage 68.08% 68.08% -0.01%
- Complexity 28940 28951 +11
============================================
Files 2519 2519
Lines 140646 140653 +7
Branches 17427 17427
============================================
+ Hits 95757 95758 +1
- Misses 37030 37036 +6
Partials 7859 7859
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ormat
Lance is Spark-only and its writer/reader only handles Spark InternalRow, not Avro. When users create a Hudi table with Lance base file format, they currently must manually set hoodie.datasource.write.record.merger.impls to DefaultSparkRecordMerger. Without this config the write path falls back to HoodieAvroRecordMerger (the global default), which is incompatible with Lance's Arrow/columnar data format.
Auto-inject DefaultSparkRecordMerger in HoodieSparkSqlWriter's mergeParamsAndGetHoodieConfig when BASE_FILE_FORMAT is LANCE and the user hasn't explicitly set RECORD_MERGE_IMPL_CLASSES. This covers all Spark write paths (DataFrame API, Spark SQL, structured streaming) and respects any explicit user override.
Describe the issue this Pull Request addresses
Summary and Changelog
Impact
Risk Level
Documentation Update
Contributor's checklist