Skip to content

fix(flink): add Apache license header to muttley/README.md#18713

Merged
codope merged 1 commit into
apache:masterfrom
shangxinli:fix/muttley-readme-license
May 10, 2026
Merged

fix(flink): add Apache license header to muttley/README.md#18713
codope merged 1 commit into
apache:masterfrom
shangxinli:fix/muttley-readme-license

Conversation

@shangxinli
Copy link
Copy Markdown
Contributor

@shangxinli shangxinli commented May 10, 2026

Describe the issue this Pull Request addresses

Master is broken: apache-rat:check fails on every new build with:

Too many files with unapproved license: 1
/home/runner/work/hudi/hudi/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/muttley/README.md

This was introduced in #18394 (merged ~2026-05-10 02:10 UTC) which added the README without the standard Apache license header.

Example failing build: https://github.com/apache/hudi/actions/runs/25632749770/job/75239286191 (from PR #18405)

Summary and Changelog

  • Prepend the standard Apache 2.0 HTML-comment license header to hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/muttley/README.md. No content changes.

Impact

Public API Changes: None.

User-Facing Changes: None — documentation file only, no behavior change.

Performance Impact: None.

Build Impact: Unblocks apache-rat:check on every module that runs from the parent reactor (currently red on master since #18394 merged). Restores green CI for all open PRs that need to be rebased / re-triggered after this lands.

Verification:

$ cd hudi-flink-datasource/hudi-flink
$ mvn -Pflink1.20 -Dscala-2.12 apache-rat:check
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 437 licenses.
[INFO] BUILD SUCCESS

Risk Level

Risk Level: none — documentation header only, no code changes.

Documentation Update

No user-facing documentation changes required. The modified file is an internal package README that already exists in master; this PR only adds the required Apache 2.0 license header so RAT compliance is satisfied.

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable (N/A — license-header fix)
  • Commits are signed and follow conventions
  • All existing tests pass

PR apache#18394 added hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/muttley/README.md
without an Apache license header, causing apache-rat:check to fail on every
new build of master ("Too many files with unapproved license: 1").

Prepend the standard Apache 2.0 HTML-comment license header so RAT passes.

Verified locally:
  cd hudi-flink-datasource/hudi-flink
  mvn -Pflink1.20 -Dscala-2.12 apache-rat:check
  -> Rat check: Summary over all files. Unapproved: 0
@shangxinli
Copy link
Copy Markdown
Contributor Author

@codope @danny0405 — sorry for the breakage. This is a one-line license-header fix (no code change). Master's apache-rat:check has been red since #18394 merged ~14h ago, so every new build (including #18405) fails. Could you fast-track this to unblock CI? Thanks.

@hudi-bot
Copy link
Copy Markdown
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@github-actions github-actions Bot added the size:S PR with lines of changes in (10, 100] label May 10, 2026
Copy link
Copy Markdown
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this was not caught in CI in the PR? Did we stop running rat checks in premerge CI?

@codope codope merged commit f2f6203 into apache:master May 10, 2026
4 of 7 checks passed
shangxinli pushed a commit to shangxinli/hudi that referenced this pull request May 11, 2026
Pick up fix from apache#18713 for muttley/README.md missing Apache license header
that was causing apache-rat:check to fail in CI.
dwshmilyss pushed a commit to dwshmilyss/hudi that referenced this pull request May 21, 2026
)

PR apache#18394 added hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/muttley/README.md
without an Apache license header, causing apache-rat:check to fail on every
new build of master ("Too many files with unapproved license: 1").

Prepend the standard Apache 2.0 HTML-comment license header so RAT passes.

Verified locally:
  cd hudi-flink-datasource/hudi-flink
  mvn -Pflink1.20 -Dscala-2.12 apache-rat:check
  -> Rat check: Summary over all files. Unapproved: 0

Co-authored-by: Xinli Shang <shangxinli@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants