Skip to content

fix(lance): Support Lance file format on Spark 4.1#18760

Merged
yihua merged 3 commits into
apache:masterfrom
voonhous:address-#18607
May 18, 2026
Merged

fix(lance): Support Lance file format on Spark 4.1#18760
yihua merged 3 commits into
apache:masterfrom
voonhous:address-#18607

Conversation

@voonhous
Copy link
Copy Markdown
Member

@voonhous voonhous commented May 17, 2026

Describe the issue this Pull Request addresses

Closes #18607.

Lance tests were previously skipped on the Spark 4.1 profile because only the lance-spark-4.0_2.13 artifact was available.

Summary and Changelog

  • Bump lance.spark.artifact from lance-spark-4.0_2.13 to lance-spark-4.1_2.13.
  • Set lance.skip.tests to false so Lance tests run under the Spark 4.1 profile.
  • Drop the related TODO comment.

Impact

Test-only. No public API or runtime behavior change.

Risk Level

none

Documentation Update

none

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@github-actions github-actions Bot added the size:XS PR with lines of changes in <= 10 label May 17, 2026
@voonhous voonhous added this to the release-1.2.0 milestone May 18, 2026
Comment thread pom.xml
@voonhous voonhous changed the title [DNM] test(lance): enable lance tests on spark4.1 profile (#18607) [DNM] test(lance): enable lance tests on spark4.1 profile May 18, 2026
@rahil-c rahil-c self-requested a review May 18, 2026 17:54
@rahil-c
Copy link
Copy Markdown
Collaborator

rahil-c commented May 18, 2026

LTGM once the ci is green.

@hudi-bot
Copy link
Copy Markdown
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua changed the title [DNM] test(lance): enable lance tests on spark4.1 profile fix(lance): Support Lance file format on Spark 4.1 May 18, 2026
Copy link
Copy Markdown
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihua yihua merged commit 055aa41 into apache:master May 18, 2026
64 of 67 checks passed
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.15%. Comparing base (071b3f1) to head (c4f5996).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master   #18760    +/-   ##
==========================================
  Coverage     68.14%   68.15%            
- Complexity    29094    29156    +62     
==========================================
  Files          2517     2521     +4     
  Lines        141113   141371   +258     
  Branches      17508    17549    +41     
==========================================
+ Hits          96160    96348   +188     
- Misses        37046    37088    +42     
- Partials       7907     7935    +28     
Flag Coverage Δ
common-and-other-modules 44.43% <ø> (+0.03%) ⬆️
hadoop-mr-java-client 44.99% <ø> (-0.01%) ⬇️
spark-client-hadoop-common 48.31% <ø> (-0.02%) ⬇️
spark-java-tests 48.94% <ø> (-0.04%) ⬇️
spark-scala-tests 44.84% <ø> (-0.08%) ⬇️
utilities 37.56% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@voonhous voonhous deleted the address-#18607 branch May 19, 2026 10:43
@yihua yihua added the engine:spark4.1 Spark 4.1 features and improvements label May 19, 2026
dwshmilyss pushed a commit to dwshmilyss/hudi that referenced this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine:spark4.1 Spark 4.1 features and improvements size:XS PR with lines of changes in <= 10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure Lance file format support on Spark 4.1

5 participants