[HUDI-995] Use Transformations, Assertions and SchemaTestUtil#1884
Merged
yanghua merged 1 commit intoapache:masterfrom Aug 1, 2020
Merged
[HUDI-995] Use Transformations, Assertions and SchemaTestUtil#1884yanghua merged 1 commit intoapache:masterfrom
yanghua merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@yanghua @vinothchandar This is another set of incremental changes for testutils re-organization. |
xushiyan
force-pushed
the
organize-testutils-classes
branch
from
ed48c2d to
a883343
Compare
xushiyan
commented
Jul 29, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/timeline/TestHoodieActiveTimeline.java
Outdated
Show resolved
Hide resolved
hudi-common/src/test/java/org/apache/hudi/common/testutils/Transformations.java
Outdated
Show resolved
Hide resolved
hudi-spark/src/test/java/org/apache/hudi/testutils/DataSourceTestUtils.java
Outdated
Show resolved
Hide resolved
yanghua
reviewed
Jul 30, 2020
hudi-common/src/test/java/org/apache/hudi/common/testutils/Transformations.java
Outdated
Show resolved
Hide resolved
hudi-common/src/test/java/org/apache/hudi/common/testutils/Transformations.java
Outdated
Show resolved
Hide resolved
hudi-common/src/test/java/org/apache/hudi/common/testutils/SchemaTestUtil.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@yanghua address the comments in the last 2 commits. thanks. |
yanghua
reviewed
Jul 31, 2020
hudi-client/src/test/java/org/apache/hudi/index/bloom/TestHoodieBloomIndex.java
Outdated
Show resolved
Hide resolved
hudi-common/src/test/java/org/apache/hudi/common/testutils/SchemaTestUtil.java
Outdated
Show resolved
Hide resolved
xushiyan
force-pushed
the
organize-testutils-classes
branch
2 times, most recently
from
783a3a1 to
523df11
Compare
- Consolidate transform functions for tests in Transformations.java - Consolidate assertion functions for tests in Assertions.java - Make use of SchemaTestUtil for loading schema from resource
xushiyan
force-pushed
the
organize-testutils-classes
branch
from
523df11 to
3d6e60d
Compare
Member
Author
|
@yanghua rebased and resolved conflicts. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are testutils functions scattered around in different modules (client, spark, common) for common transformations like HoodieRecords to HoodieKeys. This is to organize them in
Transformations.javafor ease of discovery and use.Similar purpose for adding
Assertions.java.Also make use of
SchemaTestUtilto load test schema files from resource wherever applicable.Changes
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.