Skip to content

chore: Pin third-party GitHub Actions to commit SHAs#18872

Merged
yihua merged 1 commit into
apache:masterfrom
arpitjain099:chore/pin-actions-sha
May 28, 2026
Merged

chore: Pin third-party GitHub Actions to commit SHAs#18872
yihua merged 1 commit into
apache:masterfrom
arpitjain099:chore/pin-actions-sha

Conversation

@arpitjain099
Copy link
Copy Markdown
Contributor

@arpitjain099 arpitjain099 commented May 28, 2026

Describe the issue this Pull Request addresses

Pins third-party GitHub Actions that were referenced by mutable tags to full commit SHAs in the affected workflow(s).

Summary and Changelog

A mutable tag can be repointed by the upstream owner, or by an attacker who compromises the action's repository, to arbitrary code that then runs in CI with the workflow's token and secrets. That is the failure mode behind CVE-2025-30066 (the tj-actions/changed-files compromise). Pinning to an immutable commit SHA makes the referenced code deterministic. GitHub-maintained actions/* were left on their existing refs.

Impact

CI/build hardening only. No public API, runtime behavior, or user-facing change. Each pinned SHA corresponds to the same release the tag pointed to, so workflow behavior is unchanged.

Risk Level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Copy link
Copy Markdown
Contributor

@hudi-agent hudi-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.

No reviewable code files in this PR.

cc @yihua

@hudi-bot
Copy link
Copy Markdown
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @arpitjain099 Thanks for the fix! Could you fix the PR title and description to be compliant?

@arpitjain099 arpitjain099 changed the title ci: pin third-party GitHub Actions to commit SHAs [MINOR] Pin third-party GitHub Actions to commit SHAs May 28, 2026
@arpitjain099
Copy link
Copy Markdown
Contributor Author

Thanks @yihua! Updated the title to the [MINOR] convention and filled in the Change Logs / Impact / Risk level (none) / Documentation Update sections per the template. Let me know if you'd like any further tweaks.

@voonhous voonhous changed the title [MINOR] Pin third-party GitHub Actions to commit SHAs chore: [MINOR] Pin third-party GitHub Actions to commit SHAs May 28, 2026
@yihua yihua changed the title chore: [MINOR] Pin third-party GitHub Actions to commit SHAs chore: Pin third-party GitHub Actions to commit SHAs May 28, 2026
@yihua yihua enabled auto-merge (squash) May 28, 2026 15:05
@yihua yihua merged commit 4290550 into apache:master May 28, 2026
60 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants