[HUDI-531] Add java doc for hudi test suite general classes by wangxianghu · Pull Request #1900 · apache/hudi

wangxianghu · 2020-08-02T03:30:01Z

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request

Add java doc for hudi test suite general classes

Brief change log

Add java doc for hudi test suite general classes

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage.

Committer checklist

Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

wangxianghu · 2020-08-02T03:33:46Z

Hi @yanghua , please take a look when free :)

yanghua · 2020-08-02T13:31:48Z

Hi @yanghua , please take a look when free :)

There is a conflict file. Pls resolve it then ping me. tks.

codecov-commenter · 2020-08-02T14:41:43Z

Codecov Report

Merging #1900 into master will decrease coverage by 0.69%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1900      +/-   ##
============================================
- Coverage     61.38%   60.69%   -0.70%     
+ Complexity     3799     3758      -41     
============================================
  Files           458      458              
  Lines         19573    19573              
  Branches       1959     1959              
============================================
- Hits          12015    11879     -136     
- Misses         6744     6892     +148     
+ Partials        814      802      -12

Flag	Coverage Δ	Complexity Δ
#hudicli	`67.63% <ø> (-1.86%)`	`1505.00 <ø> (-42.00)`
#hudiclient	`76.73% <ø> (-2.49%)`	`1315.00 <ø> (-42.00)`
#hudicommon	`55.07% <ø> (+0.04%)`	`1518.00 <ø> (+1.00)`
#hudihadoopmr	`38.99% <ø> (ø)`	`163.00 <ø> (ø)`
#hudihivesync	`72.01% <ø> (ø)`	`121.00 <ø> (ø)`
#hudispark	`49.24% <ø> (ø)`	`124.00 <ø> (ø)`
#huditimelineservice	`63.47% <ø> (ø)`	`47.00 <ø> (ø)`
#hudiutilities	`74.12% <ø> (ø)`	`280.00 <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...n/java/org/apache/hudi/index/hbase/HBaseIndex.java	`22.00% <0.00%> (-59.81%)`	`8.00% <0.00%> (-34.00%)`
.../index/hbase/DefaultHBaseQPSResourceAllocator.java	`55.55% <0.00%> (-44.45%)`	`3.00% <0.00%> (-2.00%)`
...org/apache/hudi/config/HoodieHBaseIndexConfig.java	`39.18% <0.00%> (-5.41%)`	`2.00% <0.00%> (ø%)`
...java/org/apache/hudi/config/HoodieWriteConfig.java	`77.25% <0.00%> (-1.45%)`	`88.00% <0.00%> (-4.00%)`
...java/org/apache/hudi/client/HoodieWriteClient.java	`75.86% <0.00%> (-0.87%)`	`46.00% <0.00%> (-1.00%)`
...ache/hudi/common/fs/inline/InMemoryFileSystem.java	`89.65% <0.00%> (+10.34%)`	`16.00% <0.00%> (+1.00%)`

wangxianghu · 2020-08-02T15:09:08Z

Hi @yanghua , please take a look when free :)

There is a conflict file. Pls resolve it then ping me. tks.

@yanghua thanks for your review, it is ready now

yanghua

@Mathieu1124 Thanks for your contribution. Left some comments. IMO, you should add more information to the doc of the classes.

yanghua · 2020-08-03T00:38:54Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/BulkInsertNode.java

bulkInsert Node -> bulk insert node?

yanghua · 2020-08-03T00:39:09Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/CleanNode.java

Node -> node?

yanghua · 2020-08-03T00:39:33Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/CompactNode.java

yanghua · 2020-08-03T00:39:47Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/HiveQueryNode.java

yanghua · 2020-08-03T00:40:51Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/scheduler/DagScheduler.java

DagScheduler -> DAG scheduler

yanghua · 2020-08-03T00:41:30Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/scheduler/DagScheduler.java

workflowDags -> workflow DAGs

execute -> executing.

wangxianghu · 2020-08-03T02:43:07Z

@Mathieu1124 Thanks for your contribution. Left some comments. IMO, you should add more information to the doc of the classes.

@yanghua Thanks for your detailed review, I will enrich and improve the docs.

pratyakshsharma · 2020-08-07T05:49:09Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/DagNode.java

execute -> execution

pratyakshsharma · 2020-08-07T05:49:29Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/DagNode.java

Execution -> execution.

wangxianghu · 2020-08-11T14:11:49Z

@yanghua this pr is ready for review now :)

yanghua

@wangxianghu Left some comments.

yanghua · 2020-08-27T11:18:06Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/configuration/DeltaConfig.java

IMO, we do not need this comment.

yanghua · 2020-08-27T11:18:14Z

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/configuration/DeltaConfig.java

yanghua · 2020-08-27T11:21:28Z

...c/main/java/org/apache/hudi/integ/testsuite/generator/GenericRecordFullPayloadGenerator.java

we may not change this.

yanghua · 2020-08-27T11:21:59Z

...c/main/java/org/apache/hudi/integ/testsuite/generator/GenericRecordFullPayloadGenerator.java

Why we should change these comment styles for fields?

Why we should change these comment styles for fields?

my bad, that`s the coding guidelines of Alibaba.
rolled back already :)

yanghua

@wangxianghu LGTM.

yanghua self-assigned this Aug 2, 2020

yanghua self-requested a review August 2, 2020 13:32

wangxianghu force-pushed the HUDI-531 branch from 8f74a29 to 9fd433a Compare August 2, 2020 14:07

yanghua reviewed Aug 3, 2020

View reviewed changes

pratyakshsharma reviewed Aug 7, 2020

View reviewed changes

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/DagNode.java Outdated

Copy link

Contributor

pratyakshsharma Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execute -> execution

pratyakshsharma reviewed Aug 7, 2020

View reviewed changes

hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/DagNode.java Outdated

Copy link

Contributor

pratyakshsharma Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execution -> execution.

wangxianghu force-pushed the HUDI-531 branch 5 times, most recently from ec52824 to 7ded665 Compare August 10, 2020 06:43

yanghua reviewed Aug 27, 2020

View reviewed changes

wangxianghu force-pushed the HUDI-531 branch from 73c05cf to b6de3aa Compare August 27, 2020 13:36

[HUDI-531]Add java doc for hudi test suite general classes

8ed7b5d

wangxianghu force-pushed the HUDI-531 branch from 9eaedf0 to 8ed7b5d Compare August 27, 2020 13:44

yanghua approved these changes Aug 28, 2020

View reviewed changes

yanghua changed the title ~~[HUDI-531]Add java doc for hudi test suite general classes~~ [HUDI-531] Add java doc for hudi test suite general classes Aug 28, 2020

yanghua merged commit fa81248 into apache:master Aug 28, 2020

wangxianghu deleted the HUDI-531 branch August 28, 2020 10:14

Conversation

wangxianghu commented Aug 2, 2020

Tips

What is the purpose of the pull request

Brief change log

Verify this pull request

Committer checklist

Uh oh!

wangxianghu commented Aug 2, 2020

Uh oh!

yanghua commented Aug 2, 2020

Uh oh!

codecov-commenter commented Aug 2, 2020

Codecov Report

Uh oh!

wangxianghu commented Aug 2, 2020

Uh oh!

yanghua left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wangxianghu commented Aug 3, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wangxianghu commented Aug 11, 2020

Uh oh!

yanghua left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yanghua left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants