Skip to content

[HUDI-1121][DOC]Provide a document describing how to use callback#1935

Merged
yanghua merged 1 commit intoapache:asf-sitefrom
wangxianghu:HUDI-1121
Aug 11, 2020
Merged

[HUDI-1121][DOC]Provide a document describing how to use callback#1935
yanghua merged 1 commit intoapache:asf-sitefrom
wangxianghu:HUDI-1121

Conversation

@wangxianghu
Copy link
Contributor

Tips

What is the purpose of the pull request

Add description of the config of write commit callback to describe how to use callback

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@wangxianghu
Copy link
Contributor Author

@yanghua @leesf please take a look when free

@yanghua yanghua self-assigned this Aug 8, 2020
@yanghua yanghua self-requested a review August 8, 2020 08:34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would add #### HoodieWriteCommitHttpCallback before the following configs since the configs belong to HoodieWriteCommitHttpCallback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would add #### HoodieWriteCommitHttpCallback before the following configs since the configs belong to HoodieWriteCommitHttpCallback

yes, my mistake.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would describe in details, such as if enables the callback but failed to callback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would describe in details, such as if enables the callback but failed to callback.

done

Comment on lines 521 to 525
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move into Write commit callback configs section would be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move into Write commit callback configs section would be better?

yes, more clear

Copy link
Contributor

@leesf leesf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanghua yanghua assigned leesf and unassigned yanghua Aug 11, 2020
@yanghua yanghua merged commit a6f991c into apache:asf-site Aug 11, 2020
@wangxianghu wangxianghu deleted the HUDI-1121 branch August 28, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants