[HUDI-1056] Fix release validate script for rc_num and release_type#2025
Merged
bvaradar merged 3 commits intoapache:masterfrom Aug 26, 2020
Merged
[HUDI-1056] Fix release validate script for rc_num and release_type#2025bvaradar merged 3 commits intoapache:masterfrom
bvaradar merged 3 commits intoapache:masterfrom
Conversation
bvaradar
approved these changes
Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Fixing release validate script for making rc_num optional and to introduce release_type(dev/release)
Brief change log
Fixing release validate script for making rc_num optional and to introduce release_type(dev/release)
Verify this pull request
This change added tests and can be verified as follows:
Committer checklist
[ x] Has a corresponding JIRA in PR title & commit
[ x] Commit message is descriptive of the change
[ x] CI is green
[x ] Necessary doc changes done or have another open PR
[x ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
Local testing:
./release/validate_staged_release.sh --release=0.6.0 --rc_num=1
/tmp/validation_scratch_dir_001 ~/Documents/personal/projects/siva_hudi/hudi_aug2020/hudi/scripts
Validating hudi-0.6.0-rc1 with release type "dev"
Checking Checksum of Source Release
Checksum Check of Source Release - [OK]
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 30225 100 30225 0 0 62191 0 --:--:-- --:--:-- --:--:-- 62063
Checking Signature
Signature Check - [OK]
Checking for binary files in source release
No Binary Files in Source Release? - [OK]
Checking for DISCLAIMER
DISCLAIMER file exists ? [OK]
Checking for LICENSE and NOTICE
License file exists ? [OK]
Notice file exists ? [OK]
Performing custom Licensing Check
Licensing Check Passed [OK]
Running RAT Check
RAT Check Passed [OK]
./release/validate_staged_release.sh --release=0.6.0
/tmp/validation_scratch_dir_001 ~/Documents/personal/projects/siva_hudi/hudi_aug2020/hudi/scripts
Validating hudi-0.6.0 with release type "dev"
Checking Checksum of Source Release
Checksum Check of Source Release - [OK]
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 30225 100 30225 0 0 104k 0 --:--:-- --:--:-- --:--:-- 103k
Checking Signature
Signature Check - [OK]
Checking for binary files in source release
No Binary Files in Source Release? - [OK]
Checking for DISCLAIMER
DISCLAIMER file exists ? [OK]
Checking for LICENSE and NOTICE
License file exists ? [OK]
Notice file exists ? [OK]
Performing custom Licensing Check
Licensing Check Passed [OK]
Running RAT Check
RAT Check Passed [OK]