Skip to content

[HUDI-1223] Remove unused UpdateHandler class in HoodieCopyOnWriteTable#2032

Merged
yanghua merged 1 commit intoapache:masterfrom
wangxianghu:HUDI-1223
Aug 26, 2020
Merged

[HUDI-1223] Remove unused UpdateHandler class in HoodieCopyOnWriteTable#2032
yanghua merged 1 commit intoapache:masterfrom
wangxianghu:HUDI-1223

Conversation

@wangxianghu
Copy link
Contributor

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@wangxianghu
Copy link
Contributor Author

@yanghua please take a look when free

@yanghua yanghua self-assigned this Aug 25, 2020
@yanghua yanghua self-requested a review August 25, 2020 11:14
Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangxianghu Thanks for your contribution. LGTM.

@yanghua
Copy link
Contributor

yanghua commented Aug 26, 2020

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit
  • Commit message is descriptive of the change
  • CI is green
  • Necessary doc changes done or have another open PR
  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

IMO, it would be better to write correct description of each PR.

@yanghua yanghua merged commit 7e68c42 into apache:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants