Skip to content

[HUDI-830] Test Suite Fixes#2039

Merged
n3nash merged 1 commit intoapache:masterfrom
modi95:test-suite-fixes
Sep 9, 2020
Merged

[HUDI-830] Test Suite Fixes#2039
n3nash merged 1 commit intoapache:masterfrom
modi95:test-suite-fixes

Conversation

@modi95
Copy link
Contributor

@modi95 modi95 commented Aug 26, 2020

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@n3nash n3nash added the status:in-progress Work in progress label Aug 26, 2020
@n3nash n3nash self-assigned this Aug 26, 2020
@nsivabalan
Copy link
Contributor

@modi95 : may I know whats the status of this patch. Can I apply this patch to run test-suite tests in my local docker? or is it still WIP ?

@modi95
Copy link
Contributor Author

modi95 commented Aug 31, 2020

@nsivabalan - should be good to patch it and run tests in local docker :)

I've left it marked as WIP as I need to update the instructions in the readme for the local docker. The updated instructions would look very similar to https://github.com/apache/hudi/blob/98c668998bb2b57145d93d3949cbb175bdaf08dd/hudi-integ-test/README.md.

@n3nash
Copy link
Contributor

n3nash commented Aug 31, 2020

@modi95 can you update this PR with the README and squash all your commits ?

@modi95 modi95 changed the title [HUDI-830][WIP] Test Suite Fixes [HUDI-830] Test Suite Fixes Sep 2, 2020
@n3nash n3nash removed the status:in-progress Work in progress label Sep 9, 2020
@n3nash
Copy link
Contributor

n3nash commented Sep 9, 2020

@modi95 This LGTM, tried it manually and it works, thanks for taking this over the finish line.

@n3nash n3nash self-requested a review September 9, 2020 05:40
@n3nash n3nash merged commit 53d1e55 into apache:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants