Merged
Conversation
Contributor
|
@modi95 : may I know whats the status of this patch. Can I apply this patch to run test-suite tests in my local docker? or is it still WIP ? |
Contributor
Author
|
@nsivabalan - should be good to patch it and run tests in local docker :) I've left it marked as WIP as I need to update the instructions in the readme for the local docker. The updated instructions would look very similar to https://github.com/apache/hudi/blob/98c668998bb2b57145d93d3949cbb175bdaf08dd/hudi-integ-test/README.md. |
Contributor
|
@modi95 can you update this PR with the README and squash all your commits ? |
0150d57 to
d9a2fcf
Compare
1f85d5b to
d065299
Compare
d7c32c7 to
efe8e71
Compare
efe8e71 to
33c5d62
Compare
Contributor
|
@modi95 This LGTM, tried it manually and it works, thanks for taking this over the finish line. |
n3nash
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.