[HUDI-1252] Remove unused code in DataSourceTestUtils

[wangxianghu]

…ceTestUtils

Tips

• Thank you very much for contributing to Apache Hudi.
• Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request

DataSourceTestUtils's inner class NoOpBulkInsertPartitioner was not used anywhere, we can remove it.

Brief change log

Remove unused class NoOpBulkInsertPartitioner in DataSourceTestUtils

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

Committer checklist

• Has a corresponding JIRA in PR title & commit

• Commit message is descriptive of the change

• CI is green

• Necessary doc changes done or have another open PR

• For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

[wangxianghu]

@yanghua @xushiyan please take a look when free

[xushiyan]

Hi @wangxianghu the removal looks good. Good catch!

While you're here, could you also clean up other unused methods in this class? namely

org.apache.hudi.testutils.DataSourceTestUtils#convertToString
org.apache.hudi.testutils.DataSourceTestUtils#convertToStringList
org.apache.hudi.testutils.DataSourceTestUtils#convertKeysToStringList

These must have been leftover during a rebase in the past. these methods have been migrated to

org.apache.hudi.common.testutils.RawTripTestPayload#recordToString
org.apache.hudi.common.testutils.RawTripTestPayload#recordsToStrings

and convertKeysToStringList merged to

hudi/hudi-spark/src/test/java/HoodieJavaApp.java

Line 197 in b8f4a30

.map(hr -> "{\"_row_key\":\"" + hr.getRecordKey() + "\",\"partition\":\"" + hr.getPartitionPath() + "\"}")

[wangxianghu]

Hi @wangxianghu the removal looks good. Good catch!

While you're here, could you also clean up other unused methods in this class? namely

org.apache.hudi.testutils.DataSourceTestUtils#convertToString
org.apache.hudi.testutils.DataSourceTestUtils#convertToStringList
org.apache.hudi.testutils.DataSourceTestUtils#convertKeysToStringList

These must have been leftover during a rebase in the past. these methods have been migrated to

org.apache.hudi.common.testutils.RawTripTestPayload#recordToString
org.apache.hudi.common.testutils.RawTripTestPayload#recordsToStrings

and convertKeysToStringList merged to

hudi/hudi-spark/src/test/java/HoodieJavaApp.java

Line 197 in b8f4a30

.map(hr -> "{\"_row_key\":\"" + hr.getRecordKey() + "\",\"partition\":\"" + hr.getPartitionPath() + "\"}")

@xushiyan thanks for your review. I have removed the methods you mentioned, PTAL :)

[xushiyan]

LGTM..will merge after CI passes.