Skip to content

[HUDI-1305] Added an API to shutdown and remove the metrics reporter.#2132

Merged
xushiyan merged 1 commit intoapache:masterfrom
prashantwason:HUDI-1305
Oct 4, 2020
Merged

[HUDI-1305] Added an API to shutdown and remove the metrics reporter.#2132
xushiyan merged 1 commit intoapache:masterfrom
prashantwason:HUDI-1305

Conversation

@prashantwason
Copy link
Member

This helps in removing reporter once the test has complete. Prevents log pollution from un-necessary metric logs.

What is the purpose of the pull request

Prevent log pollution from metrics printed to the console.

Brief change log

Added an API to shutdown the metrics reporter after tests.

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Copy link
Member

@xushiyan xushiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xushiyan
Copy link
Member

xushiyan commented Oct 3, 2020

@prashantwason could you check the conflicts please? thank you.

This helps in removing reporter once the test has complete. Prevents log pollution from un-necessary metric logs.
@vinothchandar
Copy link
Member

Rebased this against master. @xushiyan we can merge once CI passes again

@xushiyan xushiyan merged commit 6c610b9 into apache:master Oct 4, 2020
prashantwason added a commit to prashantwason/incubator-hudi that referenced this pull request Oct 19, 2020
…apache#2132)

This helps in removing reporter once the test has complete. Prevents log pollution from un-necessary metric logs.

- Added an API to shutdown the metrics reporter after tests.
prashantwason added a commit to prashantwason/incubator-hudi that referenced this pull request Oct 28, 2020
…apache#2132)

This helps in removing reporter once the test has complete. Prevents log pollution from un-necessary metric logs.

- Added an API to shutdown the metrics reporter after tests.
vinothchandar pushed a commit that referenced this pull request Oct 30, 2020
…#2132)

This helps in removing reporter once the test has complete. Prevents log pollution from un-necessary metric logs.

- Added an API to shutdown the metrics reporter after tests.
prashantwason added a commit to prashantwason/incubator-hudi that referenced this pull request Feb 22, 2021
…apache#2132)

This helps in removing reporter once the test has complete. Prevents log pollution from un-necessary metric logs.

- Added an API to shutdown the metrics reporter after tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants