Skip to content

[MINOR] Fix typo and others#2164

Merged
vinothchandar merged 4 commits intoapache:masterfrom
dugenkui03:patch-9
Oct 12, 2020
Merged

[MINOR] Fix typo and others#2164
vinothchandar merged 4 commits intoapache:masterfrom
dugenkui03:patch-9

Conversation

@dugenkui03
Copy link
Contributor

  • fix typo;

  • remove HoodieSerializationException that will never be thrown;

  • remove unused method, make HoodieException more readable.

@dugenkui03 dugenkui03 marked this pull request as draft October 10, 2020 14:00
@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #2164 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2164      +/-   ##
============================================
- Coverage     53.61%   53.61%   -0.01%     
- Complexity     2845     2846       +1     
============================================
  Files           359      359              
  Lines         16535    16544       +9     
  Branches       1777     1779       +2     
============================================
+ Hits           8866     8870       +4     
- Misses         6912     6916       +4     
- Partials        757      758       +1     
Flag Coverage Δ Complexity Δ
#hudicli 38.37% <ø> (ø) 193.00 <ø> (ø)
#hudiclient 100.00% <ø> (ø) 0.00 <ø> (ø)
#hudicommon 54.73% <100.00%> (-0.02%) 1793.00 <0.00> (ø)
#hudihadoopmr 33.05% <ø> (ø) 181.00 <ø> (ø)
#hudispark 65.48% <ø> (-0.03%) 304.00 <ø> (+1.00) ⬇️
#huditimelineservice 62.29% <ø> (ø) 50.00 <ø> (ø)
#hudiutilities 69.98% <ø> (ø) 325.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...che/hudi/common/table/log/HoodieLogFileReader.java 73.54% <ø> (ø) 25.00 <0.00> (ø)
...rg/apache/hudi/common/util/SerializationUtils.java 88.00% <ø> (ø) 3.00 <0.00> (ø)
...ava/org/apache/hudi/exception/HoodieException.java 50.00% <ø> (+16.66%) 2.00 <0.00> (ø)
...e/hudi/exception/SchemaCompatibilityException.java 33.33% <ø> (ø) 1.00 <0.00> (?)
...ain/java/org/apache/hudi/avro/HoodieAvroUtils.java 45.81% <100.00%> (ø) 31.00 <0.00> (ø)
...in/scala/org/apache/hudi/IncrementalRelation.scala 76.19% <0.00%> (-2.30%) 20.00% <0.00%> (+1.00%) ⬇️
.../org/apache/hudi/common/model/HoodieTableType.java 100.00% <0.00%> (ø) 1.00% <0.00%> (ø%)
.../apache/hudi/common/table/TableSchemaResolver.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...i/common/model/OverwriteWithLatestAvroPayload.java 64.70% <0.00%> (ø) 10.00% <0.00%> (ø%)
...del/OverwriteNonDefaultsWithLatestAvroPayload.java 78.94% <0.00%> (ø) 5.00% <0.00%> (ø%)
... and 1 more

@dugenkui03 dugenkui03 marked this pull request as ready for review October 10, 2020 15:47
@pratyakshsharma
Copy link
Contributor

LGTM.

@pratyakshsharma pratyakshsharma self-assigned this Oct 10, 2020
@vinothchandar vinothchandar merged commit d4d4c8c into apache:master Oct 12, 2020
prashantwason pushed a commit to prashantwason/incubator-hudi that referenced this pull request Feb 22, 2021
* remove HoodieSerializationException that will never be throw
* remove unused method, make HoodieException more readable
* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants