Skip to content

[WIP] [DO NOT MERGE] sample code for measuring hfile performance with column ranges#2635

Closed
satishkotha wants to merge 2 commits intoapache:masterfrom
satishkotha:sk/hfilePerf
Closed

[WIP] [DO NOT MERGE] sample code for measuring hfile performance with column ranges#2635
satishkotha wants to merge 2 commits intoapache:masterfrom
satishkotha:sk/hfilePerf

Conversation

@satishkotha
Copy link
Member

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@satishkotha satishkotha added the status:in-progress Work in progress label Mar 5, 2021
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinothchandar @prashantwason PTAL at the test code here for perf measurement and let me know if you have suggestions on layouts to try. 2 Tests above this are similar too (minor changes to layout and record type used)

Also, may be look at new method i added HoodieHFileReader#getRecordsInRange and let me know if you see any obvious performance improvements. (Functionally, it may miss few records at the beginning in some cases. i'll fix that part)

@vinothchandar vinothchandar self-assigned this Mar 10, 2021
@lw309637554 lw309637554 self-requested a review July 14, 2021 13:06
@hudi-bot
Copy link
Collaborator

hudi-bot commented Jul 14, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run travis re-run the last Travis build
  • @hudi-bot run azure re-run the last Azure build

@vinothchandar
Copy link
Member

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:in-progress Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants