Skip to content

Increase tableProperties priority#2725

Closed
NickCodeJourney wants to merge 2 commits intoapache:masterfrom
NickCodeJourney:master
Closed

Increase tableProperties priority#2725
NickCodeJourney wants to merge 2 commits intoapache:masterfrom
NickCodeJourney:master

Conversation

@NickCodeJourney
Copy link
Contributor

Increase priority of every table's property

@codecov-io
Copy link

Codecov Report

Merging #2725 (352297b) into master (8b774fe) will decrease coverage by 42.36%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #2725       +/-   ##
============================================
- Coverage     51.73%   9.36%   -42.37%     
+ Complexity     3606      48     -3558     
============================================
  Files           476      54      -422     
  Lines         22611    1996    -20615     
  Branches       2410     238     -2172     
============================================
- Hits          11697     187    -11510     
+ Misses         9891    1796     -8095     
+ Partials       1023      13     -1010     
Flag Coverage Δ Complexity Δ
hudicli ? ?
hudiclient ? ?
hudicommon ? ?
hudiflink ? ?
hudihadoopmr ? ?
hudisparkdatasource ? ?
hudisync ? ?
huditimelineservice ? ?
hudiutilities 9.36% <0.00%> (-60.37%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...s/deltastreamer/HoodieMultiTableDeltaStreamer.java 0.00% <0.00%> (-78.40%) 0.00 <0.00> (-18.00)
...va/org/apache/hudi/utilities/IdentitySplitter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...va/org/apache/hudi/utilities/schema/SchemaSet.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...a/org/apache/hudi/utilities/sources/RowSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
.../org/apache/hudi/utilities/sources/AvroSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../org/apache/hudi/utilities/sources/JsonSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...rg/apache/hudi/utilities/sources/CsvDFSSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-10.00%)
...g/apache/hudi/utilities/sources/JsonDFSSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...apache/hudi/utilities/sources/JsonKafkaSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...pache/hudi/utilities/sources/ParquetDFSSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
... and 454 more

@yanghua
Copy link
Contributor

yanghua commented Mar 30, 2021

@NickYoungPeng Hi, thanks for your contribution. Can you follow the contribution guide to create a jira ticket?

@NickCodeJourney
Copy link
Contributor Author

NickCodeJourney commented Mar 30, 2021

What is the purpose of the pull request

This pull request is that prevent the properties of common config file overwrite the properties of table level config file

Brief change log

Determine whether the table-level configuration already has the configuration. If there is no such configuration, the common will be written to the table-level configuration.

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@NickCodeJourney
Copy link
Contributor Author

@NickYoungPeng Hi, thanks for your contribution. Can you follow the contribution guide to create a jira ticket?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants