[MINOR] Fix flaky tests due to timeline server sync issue during multiwriting#2952
Closed
n3nash wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR] Fix flaky tests due to timeline server sync issue during multiwriting#2952n3nash wants to merge 1 commit intoapache:masterfrom
n3nash wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2952 +/- ##
=========================================
Coverage 54.79% 54.79%
Complexity 3817 3817
=========================================
Files 483 483
Lines 23347 23347
Branches 2491 2491
=========================================
Hits 12794 12794
Misses 9399 9399
Partials 1154 1154
Flags with carried forward coverage won't be shown. Click here to find out more. |
vinothchandar
requested changes
May 18, 2021
| props.setProperty("hoodie.deltastreamer.schemaprovider.target.schema.file", dfsBasePath + "/target.avsc"); | ||
|
|
||
| props.setProperty("include", "base.properties"); | ||
| props.setProperty("hoodie.embed.timeline.server", "false"); |
Member
There was a problem hiding this comment.
Hmmm.. we can't really do this. Its turned on by default in the real world :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Fix flaky tests for multi-writer
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.