[HUDI-2181] Fix the incorrect doc descriptions for FlinkCreateHandle#3281
Closed
rice668 wants to merge 1 commit intoapache:masterfrom
Closed
[HUDI-2181] Fix the incorrect doc descriptions for FlinkCreateHandle#3281rice668 wants to merge 1 commit intoapache:masterfrom
rice668 wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
Codecov Report
@@ Coverage Diff @@
## master #3281 +/- ##
=============================================
- Coverage 47.81% 15.75% -32.06%
+ Complexity 5569 493 -5076
=============================================
Files 936 284 -652
Lines 41629 11828 -29801
Branches 4189 981 -3208
=============================================
- Hits 19904 1864 -18040
+ Misses 19958 9801 -10157
+ Partials 1767 163 -1604
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
danny0405
reviewed
Jul 16, 2021
Contributor
There was a problem hiding this comment.
The subsequent mini-batches are appended to a file => The subsequent mini-batches are written to a file
The docs is actually correct, see FlinkMergeAndReplaceHandle.
Contributor
|
Sorry i don't think the fix is necessary, would close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.