Skip to content

[HUDI-2193] Remove state in BootstrapFunction#3296

Merged
danny0405 merged 1 commit intoapache:masterfrom
yuzhaojing:HUDI-2193
Jul 19, 2021
Merged

[HUDI-2193] Remove state in BootstrapFunction#3296
danny0405 merged 1 commit intoapache:masterfrom
yuzhaojing:HUDI-2193

Conversation

@yuzhaojing
Copy link
Contributor

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Jul 19, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run travis re-run the last Travis build
  • @hudi-bot run azure re-run the last Azure build

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #3296 (32766b2) into master (572a214) will decrease coverage by 31.80%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3296       +/-   ##
=============================================
- Coverage     47.83%   16.03%   -31.81%     
+ Complexity     5565      502     -5063     
=============================================
  Files           936      284      -652     
  Lines         41663    11869    -29794     
  Branches       4197      986     -3211     
=============================================
- Hits          19929     1903    -18026     
+ Misses        19960     9801    -10159     
+ Partials       1774      165     -1609     
Flag Coverage Δ
hudicli ?
hudiclient 0.00% <ø> (-34.53%) ⬇️
hudicommon ?
hudiflink ?
hudihadoopmr ?
hudisparkdatasource ?
hudisync 4.88% <ø> (-51.10%) ⬇️
huditimelineservice ?
hudiutilities 59.74% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...main/java/org/apache/hudi/metrics/HoodieGauge.java 0.00% <0.00%> (-100.00%) ⬇️
.../org/apache/hudi/hive/NonPartitionedExtractor.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/hudi/metrics/MetricsReporter.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/hudi/metrics/MetricsReporterType.java 0.00% <0.00%> (-100.00%) ⬇️
...rg/apache/hudi/client/bootstrap/BootstrapMode.java 0.00% <0.00%> (-100.00%) ⬇️
...he/hudi/hive/HiveStylePartitionValueExtractor.java 0.00% <0.00%> (-100.00%) ⬇️
...pache/hudi/client/utils/ConcatenatingIterator.java 0.00% <0.00%> (-100.00%) ⬇️
...che/hudi/config/HoodieMetricsPrometheusConfig.java 0.00% <0.00%> (-100.00%) ⬇️
.../hudi/execution/bulkinsert/BulkInsertSortMode.java 0.00% <0.00%> (-100.00%) ⬇️
...able/action/compact/CompactionTriggerStrategy.java 0.00% <0.00%> (-100.00%) ⬇️
... and 721 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572a214...32766b2. Read the comment docs.

@danny0405
Copy link
Contributor

Please fix the CI failure.

@yuzhaojing
Copy link
Contributor Author

Please fix the CI failure.

ok, it's my oversight.

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@danny0405 danny0405 added the engine:flink Flink integration label Jul 19, 2021
@danny0405 danny0405 self-assigned this Jul 19, 2021
@danny0405 danny0405 merged commit 2099bf4 into apache:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine:flink Flink integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants