Skip to content

[MINOR] Add a RFC template and folder#3726

Merged
vinothchandar merged 1 commit intoapache:masterfrom
vinothchandar:add-rfcs-folder
Sep 28, 2021
Merged

[MINOR] Add a RFC template and folder#3726
vinothchandar merged 1 commit intoapache:masterfrom
vinothchandar:add-rfcs-folder

Conversation

@vinothchandar
Copy link
Member

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@vinothchandar
Copy link
Member Author

templates for #3725

@hudi-bot
Copy link
Collaborator

hudi-bot commented Sep 27, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run travis re-run the last Travis build
  • @hudi-bot run azure re-run the last Azure build

@xushiyan
Copy link
Member

xushiyan commented Sep 27, 2021

@vinothchandar RFCs should be kept in asf-site? ok just read the process PR and understood the idea. Yes looks easier to keep PRs and RFC docs updated altogether. And RFCs may not be appropriate to be published on website.

Just as suggested in the other PR, the template MD file can be moved to rfc/rfc-<number>/README.md for segregating files and easy browsing.

@vinothchandar
Copy link
Member Author

Readme is common for all PRS right. Why would We need a copy per PR? Sorry, not following fully. let me also read the other PR comments fully.

@vinothchandar
Copy link
Member Author

Ok I think I understood. rfc-number is a substitution of the new rfc number

@vinothchandar
Copy link
Member Author

Addressed all feedback on other PR.

Copy link
Member

@xushiyan xushiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinothchandar vinothchandar merged commit 2aa660f into apache:master Sep 28, 2021
prashantwason pushed a commit to prashantwason/incubator-hudi that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants