Skip to content

[HUDI-2510] Added a quickstart redirect page to fix broken external links in GCP docs#3753

Merged
nsivabalan merged 2 commits intoapache:asf-sitefrom
vingov:HUDI-2510_redirect_for_quickstart_page
Oct 7, 2021
Merged

[HUDI-2510] Added a quickstart redirect page to fix broken external links in GCP docs#3753
nsivabalan merged 2 commits intoapache:asf-sitefrom
vingov:HUDI-2510_redirect_for_quickstart_page

Conversation

@vingov
Copy link

@vingov vingov commented Oct 6, 2021

Tips

What is the purpose of the pull request

This PR adds a redirect page for quickstart so that the GCP docs links are handled correctly.

Brief change log

(for example:)

  • Added a new page for quickstart which directs to the latest docs quick-start page.

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@vingov vingov changed the title Added a quickstart redirect page to fix broken external links in GCP docs [HUDI-2510] Added a quickstart redirect page to fix broken external links in GCP docs Oct 6, 2021
@vingov
Copy link
Author

vingov commented Oct 6, 2021

@rmahindra123 - I have explored the option to add a redirect in the config file, but for some reason, it's not allowing/working, hence I create a new quickstart page and did the redirection using JS.

Please review, thanks!

@rmahindra123
Copy link
Contributor

lgtm. Thanks @vingov for the quick turnaround

Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you have verified it locally.

@nsivabalan nsivabalan merged commit c6512ea into apache:asf-site Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants