[HUDI-2502] Refactor index in hudi-client module#3778
Merged
nsivabalan merged 8 commits intoapache:masterfrom Oct 28, 2021
Merged
[HUDI-2502] Refactor index in hudi-client module#3778nsivabalan merged 8 commits intoapache:masterfrom
nsivabalan merged 8 commits intoapache:masterfrom
Conversation
Collaborator
yihua
force-pushed
the
HUDI-2502-refactor-index
branch
2 times, most recently
from
9ed5c80 to
bc4493a
Compare
Contributor
Author
|
@hudi-bot run azure |
yihua
force-pushed
the
HUDI-2502-refactor-index
branch
from
bc4493a to
57f7040
Compare
yihua
changed the title
yihua
force-pushed
the
HUDI-2502-refactor-index
branch
from
57f7040 to
ac66c74
Compare
nsivabalan
requested changes
Oct 19, 2021
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
Pretty good job on this PR. You have done a great job buddy!
mostly minor comments.
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/HoodieBloomIndex.java
Outdated
Show resolved
Hide resolved
...hudi-client-common/src/main/java/org/apache/hudi/index/inmemory/HoodieInMemoryHashIndex.java
Outdated
Show resolved
Hide resolved
...-client/hudi-client-common/src/main/java/org/apache/hudi/index/simple/HoodieSimpleIndex.java
Outdated
Show resolved
Hide resolved
...nt/hudi-java-client/src/main/java/org/apache/hudi/client/common/HoodieJavaEngineContext.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
yeah, its been a long due to fix the naming to factory :) thanks.
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/SparkHoodieIndexFactory.java
Outdated
Show resolved
Hide resolved
...hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/SparkHoodieBloomIndexHelper.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/data/HoodieListData.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/data/HoodieMapPairData.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
I skimmed the approach. Looks reasonable. Main thing to think thru is any public API change,. Is it possible to retain the existing methods tagLocation(..) with a @deprecated warning for the release. We can then retire/remove them over time. Otherwise, this is a breaking change, which is a problem with rollouts
...lient/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java
Outdated
Show resolved
Hide resolved
...lient/hudi-client-common/src/main/java/org/apache/hudi/table/action/HoodieWriteMetadata.java
Outdated
Show resolved
Hide resolved
yihua
force-pushed
the
HUDI-2502-refactor-index
branch
from
ac66c74 to
6a9e2f6
Compare
Contributor
Author
|
@nsivabalan @vinothchandar I addressed all the comments. Could you take another pass? |
Contributor
Author
|
@hudi-bot run azure |
nsivabalan
reviewed
Oct 27, 2021
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/SparkHoodieIndex.java
Outdated
Show resolved
Hide resolved
...lient/hudi-spark-client/src/main/java/org/apache/hudi/index/hbase/SparkHoodieHBaseIndex.java
Show resolved
Hide resolved
...ent/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/HoodieBloomIndexHelper.java
Outdated
Show resolved
Hide resolved
...i-spark-client/src/test/java/org/apache/hudi/testutils/SparkClientFunctionalTestHarness.java
Show resolved
Hide resolved
Contributor
|
Good job on the PR. commendable work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR refactors the index in hudi-client module by using the
HoodieDataabstraction to extract common indexing logic, reduce LoC, and keep only divergent engine-specific logic in the corresponding engine client packages.Brief change log
Verify this pull request
This pull request is already covered by existing tests around indexing.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.