[HUDI-2077] Fix TestHoodieDeltaStreamerWithMultiWriter#3849
Merged
xushiyan merged 4 commits intoapache:masterfrom Oct 25, 2021
Merged
Conversation
Collaborator
nsivabalan
reviewed
Oct 23, 2021
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
Good idea on the test prep step Raymond. can. you add a comment near setUpTestTable() that this can't be used to test the deltastreamer itself as it defeats the purpose. I inspected both the tests where you have used this fixture test table. But once we land this in, we can't control if someone else may start using to test other deltastreamer cases. So, just ensure we have some comments as to when to use this.
Will wait for you to update w/ test results and then can merge this in.
xushiyan
force-pushed
the
HUDI-2077-fix-flaky-TestHoodieDeltaStreamer-with-fixture
branch
from
b4bedfd to
aadafac
Compare
xushiyan
force-pushed
the
HUDI-2077-fix-flaky-TestHoodieDeltaStreamer-with-fixture
branch
from
f59a750 to
16b061c
Compare
nsivabalan
reviewed
Oct 25, 2021
...c/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamerWithMultiWriter.java
Outdated
Show resolved
Hide resolved
nsivabalan
approved these changes
Oct 25, 2021
Member
Author
xushiyan
deleted the
HUDI-2077-fix-flaky-TestHoodieDeltaStreamer-with-fixture
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the logic of using deltastreamer to prep test table. Use fixture (compressed test table) instead.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.