[HUDI-2674] hudi hive reader should not print read values.#3910
Merged
nsivabalan merged 1 commit intoapache:masterfrom Nov 3, 2021
Merged
[HUDI-2674] hudi hive reader should not print read values.#3910nsivabalan merged 1 commit intoapache:masterfrom
nsivabalan merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@leesf @nsivabalan could you pls help me review this code. thanks this is a performance problem and data security problems. |
xiarixiaoyao
force-pushed
the
removelog
branch
from
4a2a953 to
de652ad
Compare
Collaborator
nsivabalan
reviewed
Nov 3, 2021
...doop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieCombineRealtimeRecordReader.java
Show resolved
Hide resolved
nsivabalan
approved these changes
Nov 3, 2021
Contributor
|
thanks for catching this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
now when we use hive to query hudi table and set hive.input.format=org.apache.hudi.hadoop.hive.HoodieCombineHiveInputFormat;
all read values will be print. This can lead to performance problems and data security problems,
Verify this pull request
Existing UT
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.