[WIP] Fixing synchronization in TransactionManager#4332
Closed
nsivabalan wants to merge 1 commit intoapache:masterfrom
Closed
[WIP] Fixing synchronization in TransactionManager#4332nsivabalan wants to merge 1 commit intoapache:masterfrom
nsivabalan wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
There could be a potential deadlock with the way methods in Transaction Manager is synchronized. Prior to this patch, all begin and end transaction methods were synchronized. So, consider the following scenario.
Deltastreaamer with async table service. Lets call deltastreamer as writer1 and async table service as writer2 (both will be sharing the same write client).
writer1 acquires the lock and proceeds on to do some work.
writer2 tries to begin transactions now. since lock is not available, it will be put to wait, but is within synchronized block.
writer1 finishes the work and tries to end the transaction, but since writer2 is waiting within synchronized block, writer1 can't end the transaction.
This patch fixes the issue by de-coupling the begin and end transaction methods for synchronization.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.