[HUDI-3165] Enabling InProcessLockProvider for all multi-writer tests instead of FileSystemBasedLockProviderTestClass#4427
Merged
nsivabalan merged 1 commit intoapache:masterfrom Jan 6, 2022
Conversation
nsivabalan
force-pushed
the
enableInprocesLockForTests
branch
from
440d8a1 to
980581f
Compare
manojpec
suggested changes
Dec 23, 2021
Contributor
manojpec
left a comment
manojpec
left a comment
There was a problem hiding this comment.
There are more tests that uses FilesystemBasedLockProvider by setting the property like below. Are we addressing them all as part of this ticket?
properties.setProperty("hoodie.write.lock.provider", "org.apache.hudi.client.transaction.FileSystemBasedLockProviderTestClass");
...ient-common/src/main/java/org/apache/hudi/client/transaction/lock/InProcessLockProvider.java
Show resolved
Hide resolved
Contributor
Author
|
@manojpec : I could not find any other tests using FileSystemBasedLockProviderTestClass. Can you point them to me. |
…FileSystemBasedLockProviderTestClass
nsivabalan
force-pushed
the
enableInprocesLockForTests
branch
from
980581f to
9e1cd6c
Compare
Collaborator
nsivabalan
changed the title
nsivabalan
added a commit
that referenced
this pull request
Jan 7, 2022
… instead of FileSystemBasedLockProviderTestClass (#4427)
5 tasks
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
… instead of FileSystemBasedLockProviderTestClass (apache#4427)
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
… instead of FileSystemBasedLockProviderTestClass (apache#4427)
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
… instead of FileSystemBasedLockProviderTestClass (apache#4427)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Recently we added InProcessLockProvider as a local jvm lock provider. Replacing usages of FileSystemBasedLockProviderTestClass in tests with InProcessLockProvider for multi-writer tests.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.