[HUDI-3516] Implement record iterator for HoodieDataBlock#4909
Merged
danny0405 merged 4 commits intoapache:masterfrom Mar 2, 2022
Merged
[HUDI-3516] Implement record iterator for HoodieDataBlock#4909danny0405 merged 4 commits intoapache:masterfrom
danny0405 merged 4 commits intoapache:masterfrom
Conversation
cuibo01
force-pushed
the
datablock
branch
2 times, most recently
from
fe7be60 to
8e1f10b
Compare
Contributor
Author
|
@hudi-bot run azure |
xushiyan
added
engine:flink
danny0405
changed the title
Contributor
|
Thanks for the contribution, i have reviewed and supply a patch :) |
cuibo01
force-pushed
the
datablock
branch
2 times, most recently
from
4b93451 to
9f920ed
Compare
Contributor
|
Thanks, overall looks good, i have reviewed and have another patch for this :) |
Contributor
Author
|
@danny0405 Thank you very much for your review :) |
danny0405
reviewed
Mar 1, 2022
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileReader.java
Show resolved
Hide resolved
cuibo01
force-pushed
the
datablock
branch
2 times, most recently
from
4089f89 to
696fa48
Compare
Contributor
Author
|
@hudi-bot run azure |
1 similar comment
Contributor
Author
|
@hudi-bot run azure |
Contributor
|
this is a good find and a nice optimization 👍 |
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
* Use iterator to void eager materialization to be memory friendly
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
* Use iterator to void eager materialization to be memory friendly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.