Skip to content

Comments

[MINOR] Make spark context transient to avoid serialization#4965

Closed
boneanxs wants to merge 1 commit intoapache:masterfrom
boneanxs:minor-context
Closed

[MINOR] Make spark context transient to avoid serialization#4965
boneanxs wants to merge 1 commit intoapache:masterfrom
boneanxs:minor-context

Conversation

@boneanxs
Copy link
Contributor

@boneanxs boneanxs commented Mar 7, 2022

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@boneanxs
Copy link
Contributor Author

boneanxs commented Mar 7, 2022

@hudi-bot run azure

@hudi-bot
Copy link
Collaborator

hudi-bot commented Mar 7, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@boneanxs
Copy link
Contributor Author

boneanxs commented Mar 7, 2022

Hi @leesf @wangxianghu, could you pls review this?

@nsivabalan nsivabalan added the priority:high Significant impact; potential bugs label Mar 7, 2022
@xushiyan
Copy link
Member

xushiyan commented Mar 8, 2022

@boneanxs HoodieEngineContext itself is not serializable. In HoodieTable we also mark HoodieEngineContext transient. So I don't think the change is needed. Can you confirm please?

@boneanxs
Copy link
Contributor Author

boneanxs commented Mar 8, 2022

Thanks for clearing me, I may run into the wrong code path when fixing one issue, I'll close this.

@boneanxs boneanxs closed this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:high Significant impact; potential bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants