[HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…#5170
Merged
nsivabalan merged 1 commit intoapache:masterfrom Mar 30, 2022
Merged
[HUDI-3745] Support for spark datasource options in S3EventsHoodieInc…#5170nsivabalan merged 1 commit intoapache:masterfrom
nsivabalan merged 1 commit intoapache:masterfrom
Conversation
nsivabalan
reviewed
Mar 29, 2022
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
Have you tested the patch ?
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java
Outdated
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
Outdated
Show resolved
Hide resolved
harsh1231
force-pushed
the
HUDI-3745
branch
2 times, most recently
from
b47ecd2 to
5721b60
Compare
Contributor
Author
@nsivabalan Yes |
nsivabalan
reviewed
Mar 29, 2022
| /** | ||
| *{@value #SPARK_DATASOURCE_OPTIONS} is json string, passed to the reader while loading dataset. | ||
| * Example delta streamer conf | ||
| * - --hoodie-conf hoodie.deltastreamer.source.hoodieincr.spark.datasource.options={"header":"true","encoding":"UTF-8"} |
Contributor
There was a problem hiding this comment.
sorry. lets fix the config name.
hoodie.deltastreamer.source.s3incr.spark.datasource.options
nsivabalan
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for spark datasource options in S3EventsHoodieIncrSource
While reading from spark file datasource, reader options could be provided in deltastreamer like
- --hoodie-conf hoodie.deltastreamer.source.s3incr.spark.datasource.options={"header":"true","encoding":"UTF-8"}Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.