[HUDI-3637] Exclude uncommitted log files from metadata table validation#5234
Merged
yihua merged 1 commit intoapache:masterfrom Apr 7, 2022
Merged
Conversation
Collaborator
xushiyan
pushed a commit
that referenced
this pull request
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
A Hudi file slice may contain uncommitted log files, e.g., from
AbstractTableFileSystemView::getLatestFileSlicesAPI. When the file system view is based on the file system, uncommitted log files are included for constructing Hudi file slices. When the file system view is based on metadata table, uncommitted log files are excluded. Such behavior difference does not cause any correctness issue as the compaction and clustering planning usinggetLatestFileSlices()skips the uncommitted log files when doing log block reading and merging. However, such behavior causes the metadata table validator to fail.To fix the problem, this PR adds the logic to exclude uncommitted log files when comparing two file slices with the same base file, if there is no equality.
Brief change log
HoodieMetadataTableValidatorVerify this pull request
A Hudi MOR table is constructed where there is an inflight deltacommit with written but uncommitted log files. Without this PR,
HoodieMetadataTableValidatorfails with--validate-latest-file-slicesbecause of uncommitted log files. After this PR,HoodieMetadataTableValidatorsucceeds with warning messages about uncommitted log files.Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.